Skip to content

Update build.gradle #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jennifer-ha wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update build.gradle #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
33c0b68
Update build.gradle
jennifer-ha Mar 22, 2024
0463c96
Update build.gradle
jennifer-ha Mar 22, 2024
834d9b6
Update build.gradle
jennifer-ha Mar 22, 2024
91c1839
Update video_thumbnail.dart
jennifer-ha Mar 22, 2024
6a60528
Update build.gradle
jennifer-ha Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,29 @@ version '1.0-SNAPSHOT'
buildscript {
repositories {
google()
jcenter()
mavenCentral()
}

dependencies {
classpath 'com.android.tools.build:gradle:4.1.0'
classpath 'com.android.tools.build:gradle:7.1.2'
}
}

rootProject.allprojects {
repositories {
google()
jcenter()
mavenCentral()
}
}

apply plugin: 'com.android.library'

android {
compileSdkVersion 33
compileSdkVersion 34 // Ensure this matches the latest available version

if (project.android.hasProperty("namespace")) {
namespace "xyz.justsoft.video_thumbnail"
}

defaultConfig {
minSdkVersion 16
Expand Down
2 changes: 1 addition & 1 deletion lib/video_thumbnail.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class VideoThumbnail {
static Future<String?> thumbnailFile(
{required String video,
Map<String, String>? headers,
String? thumbnailPath,
required String thumbnailPath,
Copy link

@jxstxn1 jxstxn1 Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why this is now required?

Copy link
Author

@jennifer-ha jennifer-ha Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I think you can skip this change for now. The modifications in build.gradle are essential.

ImageFormat imageFormat = ImageFormat.PNG,
int maxHeight = 0,
int maxWidth = 0,
Expand Down