Skip to content

Commit 89f1cf8

Browse files
committed
Don't use docker to speed up tests
1 parent 7298e68 commit 89f1cf8

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

.github/workflows/galata.yml

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,11 @@ jobs:
4848
run: |
4949
bash ./scripts/ci_install.sh
5050
51-
- name: Build JupyterLab dev-mode docker
52-
run: |
53-
/bin/sh ./scripts/build_docker.sh
54-
5551
- name: Launch JupyterLab
5652
run: |
5753
cd galata
5854
# Mount a volume to overwrite the server configuration
59-
docker run --rm -p 8888:8888 -v ${PWD}:/etc/jupyter -e SKIP_INTEGRITY_CHECK=true -d --name galata-jlab jupyterlab-dev
55+
jlpm start 2>&1 > /tmp/jupyterlab_server.log &
6056
6157
- name: Install browser
6258
run: |
@@ -92,9 +88,7 @@ jobs:
9288
path: |
9389
galata/playwright-report
9490
95-
- name: Stop JupyterLab
91+
- name: Print JupyterLab logs
9692
if: always()
9793
run: |
98-
docker logs galata-jlab || true
99-
docker stop galata-jlab || true
100-
docker rm -f galata-jlab || true
94+
cat /tmp/jupyterlab_server.log

0 commit comments

Comments
 (0)