Skip to content

[v3.0.0ax] Restore the "stop streaming" feature #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brichet opened this issue Mar 31, 2025 · 5 comments
Open

[v3.0.0ax] Restore the "stop streaming" feature #1297

brichet opened this issue Mar 31, 2025 · 5 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@brichet
Copy link
Contributor

brichet commented Mar 31, 2025

Problem

The "stop streaming" feature (issue and PR) has not been ported yet in V3.

I haven't found any issue about that, so I wonder if we want it back in V3 with the same design/behavior as previously (in V2).

Proposed Solution

Restore the stop streaming feature in jupyter-ai V3.

Additional context

It should now be possible to restore it using jupyterlab-chat 0.9.0, which includes a way to customize the input toolbar: jupyterlab/jupyter-chat#198.

@brichet brichet added the enhancement New feature or request label Mar 31, 2025
@brichet brichet self-assigned this Apr 1, 2025
@dlqqq
Copy link
Member

dlqqq commented Apr 1, 2025

@brichet Thanks for opening this issue & for making the upstream changes to Jupyter Chat!

@jtpio had called out that the current release plan lacks milestones & clear guidance for people to contribute. I've put together a v3.0.0ax milestone. This will track all regressions relative to v2 that we should address by the last alpha release, like this issue here. I've added this issue to the v3.0.0ax milestone for tracking.

@dlqqq dlqqq added this to the v3.0.0b0 milestone Apr 1, 2025
@dlqqq dlqqq added this to Jupyter AI Apr 1, 2025
@dlqqq dlqqq moved this to In Progress in Jupyter AI Apr 1, 2025
@dlqqq dlqqq changed the title v3: restore the "stop streaming" feature [v3.0.0ax] Restore the "stop streaming" feature Apr 1, 2025
@dlqqq
Copy link
Member

dlqqq commented Apr 2, 2025

@brichet Thank you for working on this! Summarizing some of the discussion we had this morning here:

We should explore putting the "stop streaming" button at the bottom of the AI message itself instead of replacing the Send button. Jupyter AI should work just like any other chat application, so whether the AI is still writing a response shouldn't prevent a user from sending another message.

Also, we should reach alignment on the API that Jupyter Chat will provide for this, since "Stop streaming" won't be applicable to users who aren't using Jupyter AI. That means that we'll probably have to build this in a modular fashion, i.e. Jupyter AI has to provide a plugin that somehow defines the frontend as well.

@dlqqq
Copy link
Member

dlqqq commented Apr 2, 2025

@brichet I've opened a new issue to discuss this in Jupyter Chat: jupyterlab/jupyter-chat#202

@dlqqq
Copy link
Member

dlqqq commented Apr 17, 2025

@3coins I think this would be a good issue to look into while I am away. Here's a high-level summary:

@andrii-i
Copy link
Collaborator

jupyterlab/jupyter-chat#210 is now merged and published as Jupyter Chat v0.11.0 https://github.com/jupyterlab/jupyter-chat/releases/tag/v0.11.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

4 participants