Skip to content

Commit f394f3f

Browse files
committed
add comment explaining _init_persona_classes()
1 parent 47bc2ec commit f394f3f

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

packages/jupyter-ai/jupyter_ai/personas/persona_manager.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ def _init_persona_classes(self) -> None:
6969

7070
for persona_ep in persona_eps:
7171
try:
72+
# Load a persona class from each entry point
7273
persona_class = persona_ep.load()
7374
assert issubclass(persona_class, BasePersona)
7475
persona_classes.append(persona_class)
@@ -77,6 +78,9 @@ def _init_persona_classes(self) -> None:
7778
f" - Loaded AI persona class '{class_name}' from '{class_module}' using entry point '{persona_ep.name}'."
7879
)
7980
except Exception as e:
81+
# On exception, log an error and continue.
82+
# This does not stop the surrounding `for` loop. If a persona
83+
# fails to load, it should not halt other personas from loading.
8084
self.log.error(
8185
f" - Unable to load AI persona from entry point `{persona_ep.name}` due to an exception printed below."
8286
)

0 commit comments

Comments
 (0)