From fb5168a942776ea6f2a559dd2cbe2ec11b0624c9 Mon Sep 17 00:00:00 2001 From: YuviPanda Date: Tue, 11 Feb 2025 19:01:00 -0800 Subject: [PATCH] Set template config correctly Turns out just setting it on NotebookApp doesn't set it on ServerApp now, and so all of our templates were actually just no-ops for a while. Discovered while testing https://github.com/jupyterhub/mybinder.org-deploy/pull/3178 --- mybinder/files/etc/jupyter/jupyter_notebook_config.py | 4 ++-- mybinder/values.yaml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/mybinder/files/etc/jupyter/jupyter_notebook_config.py b/mybinder/files/etc/jupyter/jupyter_notebook_config.py index b69d6744d..78f59ffc5 100644 --- a/mybinder/files/etc/jupyter/jupyter_notebook_config.py +++ b/mybinder/files/etc/jupyter/jupyter_notebook_config.py @@ -3,7 +3,7 @@ import notebook -c.NotebookApp.extra_template_paths.append("/etc/jupyter/templates") +c.ServerApp.extra_template_paths.append("/etc/jupyter/templates") # For old notebook versions we have to explicitly enable the translation @@ -21,7 +21,7 @@ # Disable JITSI integration for now jitsi_url = "" -c.NotebookApp.jinja_template_vars.update( +c.ServerApp.jinja_template_vars.update( { "binder_url": binder_launch_host + binder_request, "persistent_binder_url": binder_launch_host + binder_persistent_request, diff --git a/mybinder/values.yaml b/mybinder/values.yaml index e6bb045a6..81ea40286 100644 --- a/mybinder/values.yaml +++ b/mybinder/values.yaml @@ -42,7 +42,7 @@ tags: {} etcJupyter: jupyter_notebook_config.json: - NotebookApp: + ServerApp: allow_origin: "*" tornado_settings: trust_xheaders: true