Skip to content

Commit 43ecb3a

Browse files
authored
Merge pull request #1954 from rgaiacs/add-id-to-elements
Add id to buttons in launch form
2 parents 5579504 + cb982fc commit 43ecb3a

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

js/packages/binderhub-react-components/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@jupyterhub/binderhub-react-components",
3-
"version": "0.1.0",
3+
"version": "0.1.1",
44
"description": "Collection of React components for BinderHub",
55
"exports": {
66
"./*.jsx": "./src/*.jsx"

js/packages/binderhub-react-components/src/BuilderLauncher.jsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@ function ImageLogs({
140140
<div className="card-header d-flex align-items-baseline">
141141
<span className="flex-fill">Build Logs</span>
142142
<button
143+
id="btn-show-log"
143144
ref={toggleLogsButton}
144145
className="btn btn-link"
145146
type="button"
@@ -151,6 +152,7 @@ function ImageLogs({
151152
{logsVisible ? "hide" : "show"}
152153
</button>
153154
<button
155+
id="btn-view-raw-log"
154156
className="btn btn-link"
155157
type="button"
156158
onClick={(ev) => {

js/packages/binderhub-react-components/src/LinkGenerator.jsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -238,6 +238,7 @@ export function LinkGenerator({
238238
</div>
239239
<div className="col-2">
240240
<button
241+
id="btn-launch"
241242
className="btn btn-primary col-2 w-100"
242243
disabled={isLaunching}
243244
onClick={() => setIsLaunching(true)}
@@ -259,7 +260,7 @@ export function LinkGenerator({
259260
<button
260261
className="btn btn-outline-secondary border border-2 border-start-0"
261262
type="button"
262-
id="copy-url"
263+
id="btn-copy-url"
263264
onClick={() => copy(launchUrl)}
264265
disabled={launchUrl === ""}
265266
>
@@ -272,6 +273,7 @@ export function LinkGenerator({
272273
<div className="card-header d-flex align-items-baseline">
273274
<span className="flex-fill">Badges for your README</span>
274275
<button
276+
id="btn-show-badge"
275277
className="btn btn-link"
276278
type="button"
277279
aria-controls="badge-container"
@@ -333,7 +335,7 @@ export function LinkGenerator({
333335
<button
334336
className="btn btn-outline-secondary"
335337
type="button"
336-
id="copy-url"
338+
id="btn-copy-badge"
337339
onClick={() => copy(badgeMarkup)}
338340
disabled={badgeMarkup === ""}
339341
>

0 commit comments

Comments
 (0)