Skip to content

Commit bb84e64

Browse files
authored
Merge pull request #29 from datalayer-externals/feat/show_banner
Add show_banner to ignored_traits
2 parents a4618c3 + 785afac commit bb84e64

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

notebook_shim/shim.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ def EXTAPP_TO_NBAPP_SHIM_MSG(trait_name, extapp_name): return (
102102

103103
# A tuple of traits that shouldn't be shimmed or throw any
104104
# warnings of any kind.
105-
IGNORED_TRAITS = ("open_browser", "log_level", "log_format", "default_url")
105+
IGNORED_TRAITS = ("open_browser", "log_level", "log_format", "default_url", "show_banner")
106106

107107

108108
class NotebookConfigShimMixin:

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ test = [
3939
"pytest",
4040
"pytest-tornasync",
4141
"pytest-console-scripts",
42+
"pytest_jupyter"
4243
]
4344

4445

0 commit comments

Comments
 (0)