Skip to content

Commit 631acef

Browse files
Fix to add session only after kernel validation
1 parent 85f1b9f commit 631acef

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

notebook/services/kernels/handlers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,7 @@ def pre_get(self):
219219
# We don't want to wait forever, because browsers don't take it well when
220220
# servers never respond to websocket connection requests.
221221
kernel = self.kernel_manager.get_kernel(self.kernel_id)
222+
self._open_sessions[self.session_key] = self
222223
self.session.key = kernel.session.key
223224
future = self.request_kernel_info()
224225

@@ -251,7 +252,6 @@ def _register_session(self):
251252
if stale_handler:
252253
self.log.warning("Replacing stale connection: %s", self.session_key)
253254
yield stale_handler.close()
254-
self._open_sessions[self.session_key] = self
255255

256256
def open(self, kernel_id):
257257
super(ZMQChannelsHandler, self).open()

0 commit comments

Comments
 (0)