Skip to content

Commit fcc2c18

Browse files
committed
fix payload in events unit tests
1 parent b742290 commit fcc2c18

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

jupyter_server/services/events/handlers.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def on_close(self):
7070

7171
def validate_model(data: Dict[str, Any]) -> None:
7272
"""Validates for required fields in the JSON request body"""
73-
required_keys = {"schema_id", "version", "event"}
73+
required_keys = {"schema_id", "version", "data"}
7474
for key in required_keys:
7575
if key not in data:
7676
raise web.HTTPError(400, f"Missing `{key}` in the JSON request body.")
@@ -111,7 +111,7 @@ async def post(self):
111111
self.event_logger.emit(
112112
schema_id=payload.get("schema_id"),
113113
version=payload.get("version"),
114-
data=payload.get("event"),
114+
data=payload.get("data"),
115115
timestamp_override=get_timestamp(payload),
116116
)
117117
self.set_status(204)

tests/services/events/test_api.py

+8-8
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ async def test_subscribe_websocket(jp_ws_fetch, event_logger):
4646
{
4747
"schema_id": "event.mock.jupyter.org/message",
4848
"version": 1,
49-
"event": {
49+
"data": {
5050
"event_message": "Hello, world!"
5151
},
5252
"timestamp": "2022-05-26T12:50:00+06:00Z"
@@ -57,7 +57,7 @@ async def test_subscribe_websocket(jp_ws_fetch, event_logger):
5757
{
5858
"schema_id": "event.mock.jupyter.org/message",
5959
"version": 1,
60-
"event": {
60+
"data": {
6161
"event_message": "Hello, world!"
6262
}
6363
}
@@ -75,7 +75,7 @@ async def test_post_event(jp_fetch, event_logger_sink, payload):
7575
assert output
7676
input = json.loads(payload)
7777
data = json.loads(output)
78-
assert input["event"]["event_message"] == data["event_message"]
78+
assert input["data"]["event_message"] == data["event_message"]
7979
assert data["__timestamp__"]
8080
if "timestamp" in input:
8181
assert input["timestamp"] == data["__timestamp__"]
@@ -84,7 +84,7 @@ async def test_post_event(jp_fetch, event_logger_sink, payload):
8484
payload_3 = """\
8585
{
8686
"schema_id": "event.mock.jupyter.org/message",
87-
"event": {
87+
"data": {
8888
"event_message": "Hello, world!"
8989
}
9090
}
@@ -93,7 +93,7 @@ async def test_post_event(jp_fetch, event_logger_sink, payload):
9393
payload_4 = """\
9494
{
9595
"version": 1,
96-
"event": {
96+
"data": {
9797
"event_message": "Hello, world!"
9898
}
9999
}
@@ -110,7 +110,7 @@ async def test_post_event(jp_fetch, event_logger_sink, payload):
110110
{
111111
"schema_id": "event.mock.jupyter.org/message",
112112
"version": 1,
113-
"event": {
113+
"data": {
114114
"event_message": "Hello, world!"
115115
},
116116
"timestamp": "2022-05-26 12:50:00"
@@ -130,7 +130,7 @@ async def test_post_event_400(jp_fetch, event_logger, payload):
130130
{
131131
"schema_id": "event.mock.jupyter.org/message",
132132
"version": 1,
133-
"event": {
133+
"data": {
134134
"message": "Hello, world!"
135135
}
136136
}
@@ -140,7 +140,7 @@ async def test_post_event_400(jp_fetch, event_logger, payload):
140140
{
141141
"schema_id": "event.mock.jupyter.org/message",
142142
"version": 2,
143-
"event": {
143+
"data": {
144144
"message": "Hello, world!"
145145
}
146146
}

0 commit comments

Comments
 (0)