From f40fafb725d98c5f8f7a262baad140928519527c Mon Sep 17 00:00:00 2001 From: Tomislav Simnett Date: Thu, 27 Jan 2022 22:40:21 +0000 Subject: [PATCH 1/4] Add rubocop-rails --- fake_gem__.gemspec | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fake_gem__.gemspec b/fake_gem__.gemspec index 2617fee..60bf22b 100644 --- a/fake_gem__.gemspec +++ b/fake_gem__.gemspec @@ -12,9 +12,10 @@ Gem::Specification.new do |s| s.add_dependency 'mdl', '0.9.0' s.add_dependency 'rake' # needed by reek s.add_dependency 'reek', '6.0.3' - s.add_dependency 'rubocop', '1.10.0' - s.add_dependency 'rubocop-performance', '1.6.1' - s.add_dependency 'rubocop-rspec', '1.40.0' + s.add_dependency 'rubocop', '~> 1.25.0' + s.add_dependency 'rubocop-performance', '~> 1.13.1' + s.add_dependency 'rubocop-rspec', '~> 2.6.0' + s.add_dependency 'rubocop-rails', '~> 2.13.0' s.bindir = 'pre_commit_hooks' s.executables = [ 'run-bundle-audit', From 7caa1c90c5df849ff6d99d7c5fac1e1ca780d034 Mon Sep 17 00:00:00 2001 From: Tomislav Simnett Date: Thu, 27 Jan 2022 22:46:34 +0000 Subject: [PATCH 2/4] Update gemspec --- fake_gem__.gemspec | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/fake_gem__.gemspec b/fake_gem__.gemspec index 60bf22b..d9cc3f0 100644 --- a/fake_gem__.gemspec +++ b/fake_gem__.gemspec @@ -8,14 +8,14 @@ Gem::Specification.new do |s| s.description = 'pre-commit hooks for ruby projects' s.add_dependency 'bigdecimal' # needed by reek s.add_dependency 'bundler-audit' - s.add_dependency 'fasterer', '0.8.3' - s.add_dependency 'mdl', '0.9.0' + s.add_dependency 'fasterer', '0.9.0' + s.add_dependency 'mdl', '0.11.0' s.add_dependency 'rake' # needed by reek - s.add_dependency 'reek', '6.0.3' - s.add_dependency 'rubocop', '~> 1.25.0' - s.add_dependency 'rubocop-performance', '~> 1.13.1' - s.add_dependency 'rubocop-rspec', '~> 2.6.0' - s.add_dependency 'rubocop-rails', '~> 2.13.0' + s.add_dependency 'reek' + s.add_dependency 'rubocop' + s.add_dependency 'rubocop-performance' + s.add_dependency 'rubocop-rspec' + s.add_dependency 'rubocop-rails' s.bindir = 'pre_commit_hooks' s.executables = [ 'run-bundle-audit', From e8e9f499125d8ea479a224afaeff32a4fbd7085a Mon Sep 17 00:00:00 2001 From: Tomislav Simnett Date: Thu, 27 Jan 2022 23:41:05 +0000 Subject: [PATCH 3/4] Force exclusion of excluded files and patterns --- pre_commit_hooks/run-rubocop | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pre_commit_hooks/run-rubocop b/pre_commit_hooks/run-rubocop index 58f9a0f..3f036db 100644 --- a/pre_commit_hooks/run-rubocop +++ b/pre_commit_hooks/run-rubocop @@ -4,7 +4,7 @@ require 'English' # but pre-commit looks better if there is no output on success. args = ARGV.join(' ') puts args if ENV['DEBUG'] -output = `rubocop #{args} 2>&1` +output = `rubocop --force-exclusion #{args} 2>&1` status = $CHILD_STATUS.exitstatus puts output if status != 0 exit status From e91de5876473d293ebb9741ac2fd29c7ea6d2f86 Mon Sep 17 00:00:00 2001 From: Tomislav Simnett Date: Tue, 1 Mar 2022 12:23:29 +0000 Subject: [PATCH 4/4] Move dependency order --- fake_gem__.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fake_gem__.gemspec b/fake_gem__.gemspec index d9cc3f0..e920fd1 100644 --- a/fake_gem__.gemspec +++ b/fake_gem__.gemspec @@ -14,8 +14,8 @@ Gem::Specification.new do |s| s.add_dependency 'reek' s.add_dependency 'rubocop' s.add_dependency 'rubocop-performance' - s.add_dependency 'rubocop-rspec' s.add_dependency 'rubocop-rails' + s.add_dependency 'rubocop-rspec' s.bindir = 'pre_commit_hooks' s.executables = [ 'run-bundle-audit',