Skip to content

Commit 169356a

Browse files
Merge pull request #407 from julien-duponchelle/bytetoint
Fix usage of deprecated byte2int
2 parents 92d3e66 + bf17daf commit 169356a

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,4 @@ jobs:
2828
if: startsWith(github.ref, 'refs/tags')
2929
uses: pypa/gh-action-pypi-publish@release/v1
3030
with:
31-
password: ${{ secrets.PYPI_API_TOKEN }}
31+
password: ${{ secrets.PYPI_API_TOKEN }}

pymysqlreplication/event.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ def __init__(self, from_packet, event_size, table_map, ctl_connection, **kwargs)
6262
self.commit_flag = struct.unpack("!B", self.packet.read(1))[0] == 1
6363
self.sid = self.packet.read(16)
6464
self.gno = struct.unpack('<Q', self.packet.read(8))[0]
65-
self.lt_type = byte2int(self.packet.read(1))
65+
self.lt_type = self.packet.read(1)[0]
6666

6767
if self.mysql_version >= (5, 7):
6868
self.last_committed = struct.unpack('<Q', self.packet.read(8))[0]

pymysqlreplication/tests/test_basic.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ def ignoredEvents(self):
2525
return [GtidEvent]
2626

2727
def test_allowed_event_list(self):
28-
self.assertEqual(len(self.stream._allowed_event_list(None, None, False)), 15)
29-
self.assertEqual(len(self.stream._allowed_event_list(None, None, True)), 14)
30-
self.assertEqual(len(self.stream._allowed_event_list(None, [RotateEvent], False)), 14)
28+
self.assertEqual(len(self.stream._allowed_event_list(None, None, False)), 16)
29+
self.assertEqual(len(self.stream._allowed_event_list(None, None, True)), 15)
30+
self.assertEqual(len(self.stream._allowed_event_list(None, [RotateEvent], False)), 15)
3131
self.assertEqual(len(self.stream._allowed_event_list([RotateEvent], None, False)), 1)
3232

3333
def test_read_query_event(self):
@@ -693,11 +693,11 @@ def test_ignore_decode_errors(self):
693693
ignore_decode_errors=False
694694
)
695695
event = self.stream.fetchone()
696-
event = self.stream.fetchone()
696+
event = self.stream.fetchone()
697697
with self.assertRaises(UnicodeError) as exception:
698698
event = self.stream.fetchone()
699699
data = event.rows[0]["values"]["data"]
700-
700+
701701
# Initialize with ignore_decode_errors=True
702702
self.stream = BinLogStreamReader(
703703
self.database,
@@ -706,11 +706,11 @@ def test_ignore_decode_errors(self):
706706
ignore_decode_errors=True
707707
)
708708
self.stream.fetchone()
709-
self.stream.fetchone()
709+
self.stream.fetchone()
710710
event = self.stream.fetchone()
711711
data = event.rows[0]["values"]["data"]
712712
self.assertEqual(data, '[{"text":" Some string"}]')
713-
713+
714714
def test_drop_column(self):
715715
self.stream.close()
716716
self.execute("CREATE TABLE test_drop_column (id INTEGER(11), data VARCHAR(50))")

0 commit comments

Comments
 (0)