Merge pull request #360 from BenPH/fix-resolve-getfield-for-nonstdindentifier

Fix resolve_getfield for non standard identifiers

Author: pfitzseb

src/references.jl

@@ -203,8 +203,8 @@ function resolve_getfield(x::EXPR, parent_type::EXPR, state::State)::Bool
         if CSTParser.defines_module(parent_type) && scopeof(parent_type) isa Scope
             resolved = resolve_ref(x, scopeof(parent_type), state)
         elseif CSTParser.defines_struct(parent_type)
-            if scopehasbinding(scopeof(parent_type), valof(x))
-                setref!(x, scopeof(parent_type).names[valof(x)])
+            if scopehasbinding(scopeof(parent_type), valofid(x))
+                setref!(x, scopeof(parent_type).names[valofid(x)])
                 resolved = true
             end
         end

test/runtests.jl

@@ -646,12 +646,17 @@ f(arg) = arg
         name
         func
         func1
+        struct AnyType
+            var"anything"
+        end
+        anything(x::AnyType) = x.var"anything"
         """)
                 StaticLint.collect_hints(cst, getenv(server.files[""], server))
                 @test all(n in keys(cst.meta.scope.names) for n in ("name", "func"))
                 @test StaticLint.hasref(cst[4])
                 @test StaticLint.hasref(cst[5])
                 @test StaticLint.hasref(cst[6])
+                @test cst.args[8].args[2].args[1].args[2].args[1] in bindingof(cst.args[7].args[3].args[1]).refs
             end
         end
     end