Skip to content

remove() method does not work #30

Open
@JacekZakowicz

Description

@JacekZakowicz

Hello,

I have found out that remove() method does not work properly.
Currently it looks like this:

remove(el, binding) {
    for(let item of this.items){
      if(item.el === el){
        this.items.splice(this.items.indexOf(el), 1)
      }
    }
  }

As we can see no elements are actually removed from the array. In order to make it work properly it should be:

remove(el, binding) {
    for(let item of this.items){
      if(item.el === el){
        this.items.splice(this.items.indexOf(item), 1)
        break
      }
    }
  }

I would make a pull request but somehow can't succeed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions