Skip to content

Copyright and id shouldn't be required in Feed typings #138

@robinmetral

Description

@robinmetral

Describe the bug

copyright and id are required in the typings for FeedOptions (equivalent to "channel" in the RSS 2.0 spec):

export interface FeedOptions {
id: string;
title: string;
updated?: Date;
generator?: string;
language?: string;
ttl?: number;
feed?: string;
feedLinks?: any;
hub?: string;
docs?: string;
author?: Author;
link?: string;
description?: string;
image?: string;
favicon?: string;
copyright: string;
}

Expected behavior

They shouldn't be required. The only required channel elements are title, link and description (source).

Actual behavior

They're required and the TS compiler complains if they're left out.

Versions (please complete the following information):

(n/a)

Additional context

Is this because we need them for anything else than building the actual RSS channel? Happy to make a PR fixing this if it's unintended.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions