Cleanup with golint

Former-commit-id: 2d318c9

Author: joncrlsn

column.go

@@ -15,8 +15,10 @@ import "github.com/joncrlsn/pgutil"
 import "github.com/joncrlsn/misc"
 
 // ==================================
-// ColumnRows definition (a sortable slice of string maps)
+// Column Rows definition
 // ==================================
+
+// ColumnRows is a sortable slice of string maps
 type ColumnRows []map[string]string
 
 func (slice ColumnRows) Len() int {

foreignkey.go

@@ -12,9 +12,7 @@ import "database/sql"
 import "github.com/joncrlsn/pgutil"
 import "github.com/joncrlsn/misc"
 
-// ==================================
-// ForeignKeyRows definition
-// ==================================
+// ForeignKeyRows is a sortable string map
 type ForeignKeyRows []map[string]string
 
 func (slice ForeignKeyRows) Len() int {

grant-attribute.go

@@ -14,8 +14,10 @@ import "github.com/joncrlsn/pgutil"
 import "github.com/joncrlsn/misc"
 
 // ==================================
-// GrantAttributeRows definition (an array of string maps)
+// GrantAttributeRows definition
 // ==================================
+
+// GrantAttributeRows is a sortable slice of string maps
 type GrantAttributeRows []map[string]string
 
 func (slice GrantAttributeRows) Len() int {
@@ -140,7 +142,7 @@ func (c *GrantAttributeSchema) Change(obj interface{}) {
 
 	// Find grants in the first db that are not in the second
 	// (for this relationship and owner)
-	grantList := make([]string, 0)
+	var grantList []string
 	for _, g := range grants1 {
 		if !misc.ContainsString(grants2, g) {
 			grantList = append(grantList, g)
@@ -152,7 +154,7 @@ func (c *GrantAttributeSchema) Change(obj interface{}) {
 
 	// Find grants in the second db that are not in the first
 	// (for this relationship and owner)
-	revokeList := make([]string, 0)
+	var revokeList []string
 	for _, g := range grants2 {
 		if !misc.ContainsString(grants1, g) {
 			revokeList = append(revokeList, g)

grant-relationship.go

@@ -14,8 +14,10 @@ import "github.com/joncrlsn/pgutil"
 import "github.com/joncrlsn/misc"
 
 // ==================================
-// GrantRelationshipRows definition (an array of string maps)
+// GrantRelationshipRows definition
 // ==================================
+
+// GrantRelationshipRows is a sortable slice of string maps
 type GrantRelationshipRows []map[string]string
 
 func (slice GrantRelationshipRows) Len() int {
@@ -133,7 +135,7 @@ func (c *GrantRelationshipSchema) Change(obj interface{}) {
 
 	// Find grants in the first db that are not in the second
 	// (for this relationship and owner)
-	grantList := make([]string, 0)
+	var grantList []string
 	for _, g := range grants1 {
 		if !misc.ContainsString(grants2, g) {
 			grantList = append(grantList, g)
@@ -145,7 +147,7 @@ func (c *GrantRelationshipSchema) Change(obj interface{}) {
 
 	// Find grants in the second db that are not in the first
 	// (for this relationship and owner)
-	revokeList := make([]string, 0)
+	var revokeList []string
 	for _, g := range grants2 {
 		if !misc.ContainsString(grants1, g) {
 			revokeList = append(revokeList, g)

grant.go

@@ -15,7 +15,7 @@ import "regexp"
 
 var aclRegex = regexp.MustCompile(`([a-zA-Z0-9]+)*=([rwadDxtXUCcT]+)/([a-zA-Z0-9]+)$`)
 
-var permMap map[string]string = map[string]string{
+var permMap = map[string]string{
 	"a": "INSERT",
 	"r": "SELECT",
 	"w": "UPDATE",

index.go

@@ -15,6 +15,8 @@ import "github.com/joncrlsn/pgutil"
 // ==================================
 // IndexRows definition
 // ==================================
+
+// IndexRows is a sortable slice of string maps
 type IndexRows []map[string]string
 
 func (slice IndexRows) Len() int {

owner.go

@@ -13,8 +13,10 @@ import "github.com/joncrlsn/pgutil"
 import "github.com/joncrlsn/misc"
 
 // ==================================
-// OwnerRows definition (an array of string maps)
+// OwnerRows definition
 // ==================================
+
+// OwnerRows is a sortable slice of string maps
 type OwnerRows []map[string]string
 
 func (slice OwnerRows) Len() int {

role.go

@@ -12,9 +12,7 @@ import "sort"
 import "github.com/joncrlsn/pgutil"
 import "github.com/joncrlsn/misc"
 
-// ==================================
-// RoleRows definition (a sortable slice of string maps)
-// ==================================
+// RoleRows is a sortable slice of string maps
 type RoleRows []map[string]string
 
 func (slice RoleRows) Len() int {
@@ -101,6 +99,7 @@ where option can be:
     | USER role_name [, ...]
     | SYSID uid
 */
+
 // Add generates SQL to add the constraint/index
 func (c RoleSchema) Add() {
 	// We don't care about efficiency here so we just concat strings

sequence.go

@@ -13,8 +13,10 @@ import "github.com/joncrlsn/pgutil"
 import "github.com/joncrlsn/misc"
 
 // ==================================
-// SequenceRows definition (an slice of string maps)
+// SequenceRows definition
 // ==================================
+
+// SequenceRows is a sortable slice of string maps
 type SequenceRows []map[string]string
 
 func (slice SequenceRows) Len() int {

table.go

@@ -13,8 +13,10 @@ import "github.com/joncrlsn/pgutil"
 import "github.com/joncrlsn/misc"
 
 // ==================================
-// TableRows definition (a sortable slice of string maps)
+// TableRows definition
 // ==================================
+
+// TableRows is a sortable slice of string maps
 type TableRows []map[string]string
 
 func (slice TableRows) Len() int {