Anonymization, URIEncoding #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicevibesplus
commented
Apr 1, 2025
nicevibesplus
commented
- Anonymize configs
- encode dir and file path to support special characters in path ("File 1: Test.pdf")
jonas-hurst
requested changes
Apr 2, 2025
Owner
jonas-hurst
left a comment
jonas-hurst
left a comment
There was a problem hiding this comment.
using encodeURIComponent() on the level it is currently used leads to the breadcrumb navigation also showing the encoded strings.
Maybe consider using the encodeURIcomponent() inside construct_directiry_url() and construct_file_url() function instead?
Owner
|
thanks for the pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.