Microoptimization to use convolution type constants instead of symbols

This has a minute effect on the package image size, reducing the size
0.010MiB (-0.2%, relative to the previous commit).

Author: jmert

src/conv.jl

@@ -81,17 +81,17 @@ function plan_conv(f::AbstractArray{U,N}, K::AbstractArray{V,N}) where {N, U, V}
     return replan_conv!(plan, K)
 end
 
-function conv(f, K, shape::Symbol)
-    if shape === :full
-        return conv(f, K, ConvShape.FULL)
-    elseif shape === :same
-        return conv(f, K, ConvShape.SAME)
-    elseif shape === :valid
-        return conv(f, K, ConvShape.VALID)
-    else
-        throw(ArgumentError("Invalid convolution shape, $shape"))
-    end
-end
+#function conv(f, K, shape::Symbol)
+#    if shape === :full
+#        return conv(f, K, ConvShape.FULL)
+#    elseif shape === :same
+#        return conv(f, K, ConvShape.SAME)
+#    elseif shape === :valid
+#        return conv(f, K, ConvShape.VALID)
+#    else
+#        throw(ArgumentError("Invalid convolution shape, $shape"))
+#    end
+#end
 conv(f, K) = conv(f, K, ConvShape.FULL)
 
 function conv(f::AbstractArray{S,N}, K::AbstractArray{T,N}, shape::ConvShape.T) where {N, S, T}

src/kde.jl

@@ -484,7 +484,7 @@ function estimate(::BasicKDE, binned::UnivariateKDE{T}, info::UnivariateKDEInfo)
     info.kernel = UnivariateKDE{eltype(xx)}(xx, kernel)
 
     # convolve the data with the kernel to construct a density estimate
-    f̂ = conv(f, kernel, :same)
+    f̂ = conv(f, kernel, ConvShape.SAME)
     estim = UnivariateKDE{T}(x, f̂)
     return estim, info
 end
@@ -531,20 +531,20 @@ function estimate(method::LinearBoundaryKDE, binned::UnivariateKDE{T}, info::Uni
     K̂ = plan_conv(f, K)
 
     Θ = fill!(similar(f, R), one(R))
-    μ₀ = conv(Θ, K̂, :same)
+    μ₀ = conv(Θ, K̂, ConvShape.SAME)
 
     @simd for ii in KI
         @inbounds K[ii] *= kx[ii]
     end
     replan_conv!(K̂, K)
-    μ₁ = conv(Θ, K̂, :same)
-    f′ = conv(h, K̂, :same)
+    μ₁ = conv(Θ, K̂, ConvShape.SAME)
+    f′ = conv(h, K̂, ConvShape.SAME)
 
     @simd for ii in KI
         @inbounds K[ii] *= kx[ii]
     end
     replan_conv!(K̂, K)
-    μ₂ = conv(Θ, K̂, :same)
+    μ₂ = conv(Θ, K̂, ConvShape.SAME)
 
     # Function to force f̂ to be positive — see Eqn. 17 of Lewis (2019)
     # N.B. Mathematically f from basic KDE is strictly non-negative, but numerically we

test/conv.jl

@@ -108,5 +108,6 @@ end
     @test_throws DimensionMismatch conv!(zeros(10), f, plan)
 
     # invalid shape symbol
-    @test_throws ArgumentError conv(zeros(5), zeros(3), :invalid)
+    #   disabled because the symbol method is commented out in src/conv.jl
+    #@test_throws ArgumentError conv(zeros(5), zeros(3), :invalid)
 end