Add code testing via phpunit and/or cypress

.dockerignore

@@ -0,0 +1,3 @@
+/temp/joomla
+/vendor
+/node_modules

.env.4.4.example

@@ -0,0 +1,5 @@
+JOOMLA_VERSION=4.4-php8.1
+JOOMLA_DB_NAME=joomla
+
+MARIADB_VERSION=12
+JOOMLA_FRAMEWORK_VERSION=^2.0

.env.5.4.example

@@ -0,0 +1,5 @@
+JOOMLA_VERSION=5.4-php8.3
+JOOMLA_DB_NAME=joomla
+
+MARIADB_VERSION=12
+JOOMLA_FRAMEWORK_VERSION=^3.0

.env.6.example

@@ -0,0 +1,5 @@
+JOOMLA_VERSION=6-php8.3
+JOOMLA_DB_NAME=joomla
+
+MARIADB_VERSION=12
+JOOMLA_FRAMEWORK_VERSION=^4.0

.gitignore

@@ -17,4 +17,7 @@
 /unerrnum
 /watch*
 /vendor
-/node_modules
+/node_modules
+/.phpunit.result.cache
+/.phpunit.cache
+/.env

FOR_DEVELOPERS.md

@@ -2,6 +2,7 @@
 
 - [How to update release](#how-to-update-release-version)
 - [How to update release package](#how-to-update-release-package)
+- [Testing](#testing)
 
 ### How to update release version
 
@@ -24,3 +25,22 @@ create a release with v<version> as name
 
 upload the package file  attachments-<version>.zip into this release 
 
+
+### Testing
+
+This project uses PHPUnit for testing. To run the tests:
+
+1. Install dependencies: `composer install`
+2. Run all tests: `composer test` or `make test`
+3. Run tests with coverage: `composer test-coverage` or `make test-coverage`
+
+The test suite includes:
+- Unit tests for core functionality in `tests/unit/`
+- Integration tests in `tests/integration/` (when available)
+- Helper tests for the AttachmentsPermissions class and related functionality
+
+To run specific tests:
+- `vendor/bin/phpunit tests/unit/Helper/` - Run all helper tests
+- `vendor/bin/phpunit --testdox` - Run with human-readable output
+- `vendor/bin/phpunit --coverage-html coverage/` - Run with coverage report
+

Makefile

@@ -119,14 +119,19 @@ purge:
 	@find . -name '*.bak' -exec rm {} \;
 	@rm -f .tx/*.bak
 
-unittests:
+test:
 	@echo
 	@echo "Running unit tests..."
-	@cd test; phing -Droot=/var/www/test/joomla25/ unit_tests
+	@php vendor/bin/phpunit -c phpunit.xml
 	@echo
 
-unittests_show: unittests
-	@firefox test/coverage_result/index.html
+test-coverage:
+	@echo
+	@echo "Running unit tests with coverage..."
+	@php vendor/bin/phpunit -c phpunit.xml --coverage-html ./tests/coverage-report
+	@echo
+	@echo "Coverage report generated in tests/coverage-report/index.html"
+	@echo
 
 manual: extensions_manual/manual.rst
 	@echo "Creating Attachments Extension Manual"

attachments_component/admin/src/Helper/AttachmentsImport.php

@@ -319,7 +319,7 @@ protected static function parseFieldNames($file)
         $field = array();
         $header_line = fgetcsv($file);
         // Strip of the leading BOM, if present
-        $header_line = filter_var($header_line, FILTER_DEFAULT , FILTER_FLAG_STRIP_LOW | FILTER_FLAG_STRIP_HIGH);
+        $header_line = filter_var_array($header_line, FILTER_DEFAULT , FILTER_FLAG_STRIP_LOW | FILTER_FLAG_STRIP_HIGH);
         for ($i = 0; $i < count($header_line); $i++) {
             $field_name = trim(strtolower($header_line[$i]));
             if (in_array($field_name, AttachmentsImport::$field_names)) {

attachments_component/admin/src/Helper/AttachmentsPermissions.php

@@ -35,7 +35,7 @@ class AttachmentsPermissions
     /**
      * Get the actions
      *
-     * @return an array of which actions are permitted for this user
+     * @return Registry a registry object of which actions are permitted for this user
      */
     public static function getActions($user_id = null)
     {
@@ -47,7 +47,7 @@ public static function getActions($user_id = null)
             $user = Factory::getApplication()->getIdentity();
         }
 
-        $result = new Registry();
+        $result = new Registry(null, "");
 
         $assetName = 'com_attachments';
 

attachments_component/admin/src/Helper/AttachmentsUpdate.php

@@ -45,6 +45,12 @@ class AttachmentsUpdate
     public static function checkAccess()
     {
         $app = Factory::getApplication();
+
+        // Skip authorization check in CLI context
+        if ($app->isClient('cli')) {
+            return;
+        }
+
         $user = $app->getIdentity();
         if ($user === null or !$user->authorise('core.admin', 'com_attachments')) {
             throw new \Exception(Text::_('JERROR_ALERTNOAUTHOR') . ' (ERR 67)', 404);

attachments_component/install.attachments.php

@@ -200,27 +200,6 @@ public function preflight(string $type, InstallerAdapter $adapter): bool
             return false;
         }
 
-        // If there is debris from a previous failed attempt to install Attachments, delete it
-        // NOTE: Creating custom query because using JComponentHelper::isEnabled insists on
-        //       printing a warning if the component is not installed
-        $db = Factory::getContainer()->get('DatabaseDriver');
-        $query = $db->getQuery(true);
-        $query->select('extension_id AS id, enabled');
-        $query->from('#__extensions');
-        $query->where($query->qn('type') . ' = ' . $db->quote('component'));
-        $query->where($query->qn('element') . ' = ' . $db->quote('com_attachments'));
-        $db->setQuery($query);
-        if ($db->loadResult() == 0) {
-            if (
-                Folder::exists(JPATH_ROOT . '/components/com_attachments')
-                or Folder::exists(JPATH_ROOT . '/administrator/components/com_attachments')
-            ) {
-                $msg = Text::_('ATTACH_ERROR_UINSTALL_OLD_VERSION');
-                $app->enqueueMessage($msg, 'error');
-                return false;
-            }
-        }
-
         // Temporarily move the attachments directory out of the way to avoid conflicts
         $attachdir = JPATH_ROOT . '/attachments';
         if (Folder::exists($attachdir)) {

composer.json

@@ -1,19 +1,38 @@
 {
     "require-dev": {
-        "phpunit/phpunit": "^10.3",
-        "phpcompatibility/php-compatibility": "^10.0@dev"
+        "phpunit/phpunit": "^10.0",
+        "phpcompatibility/php-compatibility": "^9.0",
+        "joomla/test": "^4.0",
+        "joomla/string": "^4.0",
+        "joomla/registry": "^4.0",
+        "joomla/database": "^4.0",
+        "joomla/application": "^4.0",
+        "joomla/di": "^4.0",
+        "joomla/session": "^4.0",
+        "joomla/language": "^4.0",
+        "joomla/filter": "^4.0",
+        "joomla/filesystem": "^4.1"
+    },
+    "autoload": {
+        "psr-4": {
+            "JMCameron\\Component\\Attachments\\Administrator\\": "attachments_component/admin/src/",
+            "JMCameron\\Component\\Attachments\\Site\\": "attachments_component/site/src/"
+        }
     },
     "autoload-dev": {
-        "Tests\\": "tests",
-        "JMCameron\\Component\\Attachments\\Administrator\\": "attachments_component/admin/src/",
-        "JMCameron\\Component\\Attachments\\Site\\": "attachments_component/site/src/"
+        "psr-4": {
+            "Tests\\": "tests/",
+            "Joomla\\CMS\\": "temp/joomla/libraries/src/"
+        }
     },
     "config": {
         "allow-plugins": {
             "dealerdirect/phpcodesniffer-composer-installer": true
         }
     },
     "scripts": {
-        "check-compatibility": "phpcs -p . --standard=PHPCompatibility --runtime-set testVersion 7.4- --ignore=*/vendor/*,temp/*"
+        "check-compatibility": "phpcs -p . --standard=PHPCompatibility --runtime-set testVersion 7.4- --ignore=*/vendor/*,temp/*",
+        "test": "phpunit -c phpunit.xml",
+        "test-coverage": "phpunit -c phpunit.xml --coverage-html ./tests/coverage-report"
     }
 }