Skip to content

Conversation

@parapente
Copy link
Collaborator

Fixes #145

@parapente
Copy link
Collaborator Author

@JLTRY sorry it contains the fixes from PR #144 so review that first.

Copy link
Collaborator

@JLTRY JLTRY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For AttachmentsHelper the id is quite long, prefer
$randomId = base64_encode('add' . $parent_id);
except that quite good you can merge

@JLTRY
Copy link
Collaborator

JLTRY commented Jul 17, 2025

Also the screen for updating is quite large with a scroller (was already like it)
image
I modified for instance with
Pat2811.txt
I let you adjust

@parapente
Copy link
Collaborator Author

The screen seems a bit off from what it should be.

attachments

And it is the same when in full screen. There is some extra vertical space but I get no scrollbars. I have to set a very small height/width to get a scrollbar. Maybe something else is eating up the space? Some bootstrap class that you have overriden maybe?

@JLTRY
Copy link
Collaborator

JLTRY commented Jul 17, 2025

I will check later on my side for the screen, to see why the screen it like it at my side . Let merge the change

@JLTRY JLTRY merged commit fff7403 into master Jul 17, 2025
@parapente parapente deleted the parapente/issue145 branch July 17, 2025 12:11
@JLTRY
Copy link
Collaborator

JLTRY commented Jul 17, 2025

I fixed the width of the iframe locally for my template.
For an unknow reason the width height were small
I put by default
iframe { width:100%; height:100%; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The add attachment link on the articles of the front page does not correspond to the right article

3 participants