Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

Commit be16477

Browse files
authored
Fix image repo host not found error (#18)
## Summary Fix image repo host not found error ## How was it tested? launchpad up ## Is this change backwards-compatible? yes
1 parent baa014e commit be16477

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

launchpad/publish.go

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ type PublishPlan struct {
114114

115115
type PublishOutput struct {
116116
Duration time.Duration
117-
RegistryHost registryHost
117+
registryHost registryHost
118118
publishedImages map[string]string
119119
}
120120

@@ -154,6 +154,13 @@ func (do *PublishOutput) SetDuration(d time.Duration) {
154154
}
155155
}
156156

157+
func (o *PublishOutput) RegistryHost() string {
158+
if o == nil {
159+
return ""
160+
}
161+
return string(o.registryHost)
162+
}
163+
157164
func getRemoteRegistryInfo(
158165
ctx context.Context,
159166
pubOpts *PublishOptions,
@@ -479,7 +486,7 @@ func (p *Pad) publishDockerImage(
479486

480487
return &PublishOutput{
481488
publishedImages: published,
482-
RegistryHost: plan.registry.GetHost(),
489+
registryHost: plan.registry.GetHost(),
483490
}, nil
484491
}
485492

padcli/command/deploy.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ func makeDeployOptions(
6363
helm.NewImageProvider(
6464
buildOutput.Image.String(),
6565
publishOutput.PublishedImages(),
66-
string(publishOutput.RegistryHost),
66+
publishOutput.RegistryHost(),
6767
),
6868
jetCfg,
6969
cluster,

0 commit comments

Comments
 (0)