Remove (default) first option on `ConnectionType

jerowork · jerowork · commit dd5ce0a87b9e · 2025-05-23T17:38:27.000+02:00
Since the EdgeTypeResolver does not define a default first value anymore,
there is no need for a `first` option on ConnectionType.
diff --git a/src/Attribute/Option/ConnectionType.php b/src/Attribute/Option/ConnectionType.php
@@ -11,6 +11,5 @@
      */
     public function __construct(
         public string $edgeType,
-        public int $first = 10,
     ) {}
 }
diff --git a/src/Node/TypeReference/ConnectionTypeReference.php b/src/Node/TypeReference/ConnectionTypeReference.php
@@ -7,7 +7,6 @@
 /**
  * @phpstan-type ConnectionReferencePayload array{
  *     className: class-string,
- *     first: int,
  *     isValueNullable: bool
  * }
  *
@@ -22,7 +21,6 @@ final class ConnectionTypeReference implements TypeReference
      */
     public function __construct(
         public readonly string $className,
-        public readonly int $first,
         bool $isValueNullable,
     ) {
         $this->isValueNullable = $isValueNullable;
@@ -31,9 +29,9 @@ public function __construct(
     /**
      * @param class-string $className
      */
-    public static function create(string $className, int $first): self
+    public static function create(string $className): self
     {
-        return new self($className, $first, false);
+        return new self($className, false);
     }
 
     /**
@@ -43,7 +41,6 @@ public function toArray(): array
     {
         return [
             'className' => $this->className,
-            'first' => $this->first,
             'isValueNullable' => $this->isValueNullable(),
         ];
     }
@@ -55,7 +52,6 @@ public static function fromArray(array $payload): ConnectionTypeReference
     {
         return new self(
             $payload['className'],
-            $payload['first'],
             $payload['isValueNullable'],
         );
     }
@@ -64,7 +60,6 @@ public function equals(TypeReference $reference): bool
     {
         return $reference instanceof self
             && $reference->className === $this->className
-            && $reference->first === $this->first
             && $reference->isValueNullable === $this->isValueNullable;
     }
 }
diff --git a/src/NodeParser/TypeReferenceDecider.php b/src/NodeParser/TypeReferenceDecider.php
@@ -40,7 +40,7 @@ public function getTypeReference(?ReflectionType $reflectionType, ?TypedAttribut
             $attributeType = $attribute->getType();
 
             if ($attributeType instanceof ConnectionType) {
-                return ConnectionTypeReference::create($attributeType->edgeType, $attributeType->first);
+                return ConnectionTypeReference::create($attributeType->edgeType);
             }
 
             if ($attributeType instanceof ListType) {
@@ -65,7 +65,7 @@ public function getTypeReference(?ReflectionType $reflectionType, ?TypedAttribut
 
             if ($attributeType instanceof NullableType) {
                 if ($attributeType->type instanceof ConnectionType) {
-                    return ConnectionTypeReference::create($attributeType->type->edgeType, $attributeType->type->first)
+                    return ConnectionTypeReference::create($attributeType->type->edgeType)
                         ->setNullableValue();
                 }
 
diff --git a/tests/Node/TypeReference/ConnectionTypeReferenceTest.php b/tests/Node/TypeReference/ConnectionTypeReferenceTest.php
@@ -17,15 +17,15 @@ final class ConnectionTypeReferenceTest extends TestCase
     #[Test]
     public function itShouldCreateBaseObject(): void
     {
-        $reference = ConnectionTypeReference::create(stdClass::class, 10);
+        $reference = ConnectionTypeReference::create(stdClass::class);
 
         self::assertSame(stdClass::class, $reference->className);
     }
 
     #[Test]
     public function itShouldSetValueNullable(): void
     {
-        $reference = ConnectionTypeReference::create(stdClass::class, 10);
+        $reference = ConnectionTypeReference::create(stdClass::class);
 
         self::assertFalse($reference->isValueNullable());
 
@@ -37,7 +37,7 @@ public function itShouldSetValueNullable(): void
     #[Test]
     public function itShouldSerializeAndDeserialize(): void
     {
-        $reference = ConnectionTypeReference::create(stdClass::class, 10)
+        $reference = ConnectionTypeReference::create(stdClass::class)
             ->setNullableValue();
 
         self::assertEquals(ConnectionTypeReference::fromArray($reference->toArray()), $reference);
diff --git a/tests/NodeParser/TypeReferenceDeciderTest.php b/tests/NodeParser/TypeReferenceDeciderTest.php
@@ -266,10 +266,10 @@ public function itShouldReturnConnectionFromAttribute(): void
         $parameters = $methods->getParameters();
         $type = $parameters[0]->getType();
 
-        $reference = $decider->getTypeReference($type, new Mutation(type: new ConnectionType(TestType::class, 12)));
+        $reference = $decider->getTypeReference($type, new Mutation(type: new ConnectionType(TestType::class)));
 
         self::assertInstanceOf(ReflectionNamedType::class, $type);
-        self::assertTrue($reference?->equals(ConnectionTypeReference::create(TestType::class, 12)));
+        self::assertTrue($reference?->equals(ConnectionTypeReference::create(TestType::class)));
     }
 
     #[Test]
@@ -282,10 +282,10 @@ public function itShouldReturnNullableConnectionFromAttribute(): void
         $parameters = $methods->getParameters();
         $type = $parameters[0]->getType();
 
-        $reference = $decider->getTypeReference($type, new Mutation(type: new NullableType(new ConnectionType(TestType::class, 12))));
+        $reference = $decider->getTypeReference($type, new Mutation(type: new NullableType(new ConnectionType(TestType::class))));
 
         self::assertInstanceOf(ReflectionNamedType::class, $type);
-        self::assertTrue($reference?->equals(ConnectionTypeReference::create(TestType::class, 12)->setNullableValue()));
+        self::assertTrue($reference?->equals(ConnectionTypeReference::create(TestType::class)->setNullableValue()));
     }
 
     #[Test]
diff --git a/tests/ParserTest.php b/tests/ParserTest.php
@@ -190,7 +190,7 @@ public function itShouldParseDirectory(): void
                         'status',
                     ),
                 ],
-                ConnectionTypeReference::create(UserType::class, 10),
+                ConnectionTypeReference::create(UserType::class),
                 'withConnectionOutput',
                 null,
             ),
@@ -547,7 +547,7 @@ public function itShouldParseDirectory(): void
                         null,
                     ),
                     new FieldNode(
-                        ConnectionTypeReference::create(AgentType::class, 10)->setNullableValue(),
+                        ConnectionTypeReference::create(AgentType::class)->setNullableValue(),
                         'users',
                         null,
                         [
diff --git a/tests/Resolver/Type/Connection/EdgeTypeResolverTest.php b/tests/Resolver/Type/Connection/EdgeTypeResolverTest.php
@@ -78,7 +78,7 @@ public function itShouldCreateEdgeTypeAndStoreInRegistry(): void
         self::assertFalse($this->builtTypesRegistry->hasType('TestEdge'));
 
         $edgeType = $this->resolver->createEdgeType(
-            ConnectionTypeReference::create(TestType::class, 10),
+            ConnectionTypeReference::create(TestType::class),
             $typeNode,
             new TypeResolverSelector([
                 new ObjectTypeResolver($this->astContainer, $this->fieldResolver),
@@ -141,7 +141,7 @@ public function itShouldGuardThatCursorIsCustomScalarWhenItsAnObjectType(): void
         self::expectExceptionMessage('Invalid object type cursor connection edge type');
 
         $this->resolver->createEdgeType(
-            ConnectionTypeReference::create(TestType::class, 10),
+            ConnectionTypeReference::create(TestType::class),
             $typeNode,
             new TypeResolverSelector([
                 new ObjectTypeResolver($this->astContainer, $this->fieldResolver),
@@ -175,7 +175,7 @@ public function itShouldGetEdgeTypeFromRegistry(): void
         self::assertTrue($this->builtTypesRegistry->hasType('TestEdge'));
 
         $edgeType = $this->resolver->createEdgeType(
-            ConnectionTypeReference::create(TestType::class, 10),
+            ConnectionTypeReference::create(TestType::class),
             new TypeNode(
                 TestType::class,
                 'Test',
diff --git a/tests/Resolver/Type/TypeResolverSelectorTest.php b/tests/Resolver/Type/TypeResolverSelectorTest.php
@@ -39,7 +39,7 @@ public function itShouldThrowExceptionWhenNoResolverFound(): void
     {
         self::expectException(LogicException::class);
 
-        $this->selector->getResolver(ConnectionTypeReference::create(stdClass::class, 10));
+        $this->selector->getResolver(ConnectionTypeReference::create(stdClass::class));
     }
 
     #[Test]
diff --git a/tests/SchemaBuilderTest.php b/tests/SchemaBuilderTest.php
@@ -264,7 +264,6 @@ public function itShouldBuildSchema(): void
                         'name' => 'first',
                         'type' => Type::int(),
                         'description' => 'Connection: return the first # items',
-                        'defaultValue' => 10,
                     ],
                     [
                         'name' => 'after',
@@ -745,7 +744,6 @@ public function itShouldBuildSchema(): void
                                             'name' => 'first',
                                             'type' => Type::int(),
                                             'description' => 'Connection: return the first # items',
-                                            'defaultValue' => 10,
                                         ],
                                         [
                                             'name' => 'after',
@@ -1160,7 +1158,6 @@ public function itShouldBuildSchema(): void
                                     'name' => 'first',
                                     'type' => Type::int(),
                                     'description' => 'Connection: return the first # items',
-                                    'defaultValue' => 10,
                                 ],
                                 [
                                     'name' => 'after',

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,5 @@`
`11`	`11`	`*/`
`12`	`12`	`public function __construct(`
`13`	`13`	`public string $edgeType,`
`14`		`- public int $first = 10,`
`15`	`14`	`) {}`
`16`	`15`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,6 @@`
`7`	`7`	`/**`
`8`	`8`	`* @phpstan-type ConnectionReferencePayload array{`
`9`	`9`	`* className: class-string,`
`10`		`- * first: int,`
`11`	`10`	`* isValueNullable: bool`
`12`	`11`	`* }`
`13`	`12`	`*`
`@@ -22,7 +21,6 @@ final class ConnectionTypeReference implements TypeReference`
`22`	`21`	`*/`
`23`	`22`	`public function __construct(`
`24`	`23`	`public readonly string $className,`
`25`		`- public readonly int $first,`
`26`	`24`	`bool $isValueNullable,`
`27`	`25`	`) {`
`28`	`26`	`$this->isValueNullable = $isValueNullable;`
`@@ -31,9 +29,9 @@ public function __construct(`
`31`	`29`	`/**`
`32`	`30`	`* @param class-string $className`
`33`	`31`	`*/`
`34`		`- public static function create(string $className, int $first): self`
	`32`	`+ public static function create(string $className): self`
`35`	`33`	`{`
`36`		`- return new self($className, $first, false);`
	`34`	`+ return new self($className, false);`
`37`	`35`	`}`
`38`	`36`
`39`	`37`	`/**`
`@@ -43,7 +41,6 @@ public function toArray(): array`
`43`	`41`	`{`
`44`	`42`	`return [`
`45`	`43`	`'className' => $this->className,`
`46`		`- 'first' => $this->first,`
`47`	`44`	`'isValueNullable' => $this->isValueNullable(),`
`48`	`45`	`];`
`49`	`46`	`}`
`@@ -55,7 +52,6 @@ public static function fromArray(array $payload): ConnectionTypeReference`
`55`	`52`	`{`
`56`	`53`	`return new self(`
`57`	`54`	`$payload['className'],`
`58`		`- $payload['first'],`
`59`	`55`	`$payload['isValueNullable'],`
`60`	`56`	`);`
`61`	`57`	`}`
`@@ -64,7 +60,6 @@ public function equals(TypeReference $reference): bool`
`64`	`60`	`{`
`65`	`61`	`return $reference instanceof self`
`66`	`62`	`&& $reference->className === $this->className`
`67`		`- && $reference->first === $this->first`
`68`	`63`	`&& $reference->isValueNullable === $this->isValueNullable;`
`69`	`64`	`}`
`70`	`65`	`}`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ public function getTypeReference(?ReflectionType $reflectionType, ?TypedAttribut`
`40`	`40`	`$attributeType = $attribute->getType();`
`41`	`41`
`42`	`42`	`if ($attributeType instanceof ConnectionType) {`
`43`		`- return ConnectionTypeReference::create($attributeType->edgeType, $attributeType->first);`
	`43`	`+ return ConnectionTypeReference::create($attributeType->edgeType);`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`if ($attributeType instanceof ListType) {`
`@@ -65,7 +65,7 @@ public function getTypeReference(?ReflectionType $reflectionType, ?TypedAttribut`
`65`	`65`
`66`	`66`	`if ($attributeType instanceof NullableType) {`
`67`	`67`	`if ($attributeType->type instanceof ConnectionType) {`
`68`		`- return ConnectionTypeReference::create($attributeType->type->edgeType, $attributeType->type->first)`
	`68`	`+ return ConnectionTypeReference::create($attributeType->type->edgeType)`
`69`	`69`	`->setNullableValue();`
`70`	`70`	`}`
`71`	`71`
Original file line number	Diff line number	Diff line change
`@@ -17,15 +17,15 @@ final class ConnectionTypeReferenceTest extends TestCase`
`17`	`17`	`#[Test]`
`18`	`18`	`public function itShouldCreateBaseObject(): void`
`19`	`19`	`{`
`20`		`- $reference = ConnectionTypeReference::create(stdClass::class, 10);`
	`20`	`+ $reference = ConnectionTypeReference::create(stdClass::class);`
`21`	`21`
`22`	`22`	`self::assertSame(stdClass::class, $reference->className);`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`#[Test]`
`26`	`26`	`public function itShouldSetValueNullable(): void`
`27`	`27`	`{`
`28`		`- $reference = ConnectionTypeReference::create(stdClass::class, 10);`
	`28`	`+ $reference = ConnectionTypeReference::create(stdClass::class);`
`29`	`29`
`30`	`30`	`self::assertFalse($reference->isValueNullable());`
`31`	`31`
`@@ -37,7 +37,7 @@ public function itShouldSetValueNullable(): void`
`37`	`37`	`#[Test]`
`38`	`38`	`public function itShouldSerializeAndDeserialize(): void`
`39`	`39`	`{`
`40`		`- $reference = ConnectionTypeReference::create(stdClass::class, 10)`
	`40`	`+ $reference = ConnectionTypeReference::create(stdClass::class)`
`41`	`41`	`->setNullableValue();`
`42`	`42`
`43`	`43`	`self::assertEquals(ConnectionTypeReference::fromArray($reference->toArray()), $reference);`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ public function itShouldThrowExceptionWhenNoResolverFound(): void`
`39`	`39`	`{`
`40`	`40`	`self::expectException(LogicException::class);`
`41`	`41`
`42`		`- $this->selector->getResolver(ConnectionTypeReference::create(stdClass::class, 10));`
	`42`	`+ $this->selector->getResolver(ConnectionTypeReference::create(stdClass::class));`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`#[Test]`