Skip to content

Commit 5b340a0

Browse files
authored
Require Jenkins 2.452.4 or newer (#135)
* Use standard dependabot configuration and format * Require Jenkins 2.452.4 or newer Jenkins 2.452.4 includes a critical security fix that make it a good minimum Jenkins version. It is also one of the versions recommended: https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ As of June 2024, 60% of installations of the most recent release were using Jenkins 2.440 or newer. With advisories and typical uprade patterns, the percentage is certainly even higher now. * Use 0.10.0 as next release Upgrading minimum Jenkins version * Remove description attribute from pom No longer used by Jenkins tooling, see index.jelly
1 parent 0d8809b commit 5b340a0

File tree

3 files changed

+17
-17
lines changed

3 files changed

+17
-17
lines changed

.github/dependabot.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
# https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file
2-
---
1+
# https://docs.github.com/code-security/dependabot/dependabot-version-updates/configuring-dependabot-version-updates
2+
33
version: 2
44
updates:
5-
- package-ecosystem: "maven"
6-
directory: "/"
7-
schedule:
8-
interval: "monthly"
9-
- package-ecosystem: "github-actions"
10-
directory: "/"
11-
schedule:
12-
interval: "monthly"
5+
- package-ecosystem: maven
6+
directory: /
7+
schedule:
8+
interval: monthly
9+
- package-ecosystem: github-actions
10+
directory: /
11+
schedule:
12+
interval: monthly

pom.xml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
33
<modelVersion>4.0.0</modelVersion>
4+
45
<parent>
56
<groupId>org.jenkins-ci.plugins</groupId>
67
<artifactId>plugin</artifactId>
@@ -13,7 +14,6 @@
1314
<version>${revision}${changelist}</version>
1415
<packaging>hpi</packaging>
1516
<name>Git Parameter Plug-In</name>
16-
<description>Adds ability to choose branches, tags or revisions from git repositories configured in project.</description>
1717
<url>https://github.com/jenkinsci/${project.artifactId}-plugin</url>
1818

1919
<licenses>
@@ -48,10 +48,11 @@
4848
</scm>
4949

5050
<properties>
51-
<revision>0.9.20</revision>
51+
<revision>0.10.0</revision>
5252
<changelist>-SNAPSHOT</changelist>
5353
<!-- Baseline Jenkins version you use to build and test the plugin. Users must have this version or newer to run. -->
54-
<jenkins.version>2.387.3</jenkins.version>
54+
<jenkins.baseline>2.452</jenkins.baseline>
55+
<jenkins.version>${jenkins.baseline}.4</jenkins.version>
5556
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
5657
<spotless.check.skip>false</spotless.check.skip>
5758
</properties>
@@ -60,8 +61,8 @@
6061
<dependencies>
6162
<dependency>
6263
<groupId>io.jenkins.tools.bom</groupId>
63-
<artifactId>bom-2.387.x</artifactId>
64-
<version>2543.vfb_1a_5fb_9496d</version>
64+
<artifactId>bom-${jenkins.baseline}.x</artifactId>
65+
<version>3559.vb_5b_81183b_d23</version>
6566
<type>pom</type>
6667
<scope>import</scope>
6768
</dependency>

src/test/java/net/uaznia/lukanus/hudson/plugins/gitparameter/GitParameterDefinitionTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@
3636
import java.util.ArrayList;
3737
import java.util.Arrays;
3838
import java.util.List;
39-
import java.util.concurrent.ExecutionException;
4039
import net.sf.json.JSONObject;
4140
import net.uaznia.lukanus.hudson.plugins.gitparameter.GitParameterDefinition.DescriptorImpl;
4241
import net.uaznia.lukanus.hudson.plugins.gitparameter.jobs.JobWrapper;
@@ -701,7 +700,7 @@ public void testWorkflowJobWithCpsScmFlowDefinition() throws IOException {
701700
}
702701

703702
@Test
704-
public void testWorkflowJobWithCpsFlowDefinition() throws IOException, InterruptedException, ExecutionException {
703+
public void testWorkflowJobWithCpsFlowDefinition() throws Exception {
705704
WorkflowJob p = jenkins.createProject(WorkflowJob.class, "wfj");
706705
String script =
707706
"node {\n" + " git url: '" + GIT_PARAMETER_REPOSITORY_URL + "' \n" + " echo 'Some message'\n" + "}";

0 commit comments

Comments
 (0)