[FEATURE] Allow for waiting until loop is complete before switching slide

[mateuszdrwal]

Description

I like continuity, and I have a few slides with relatively quick loops. It would be great to have a kwarg for next_slide that makes it so that if the slide is looping, after the next slide is triggered it waits for the current loop to end before proceeding. That way the visuals never suddenly jump to a new state which can be quite jarring.

Screenshots

No response

Additional information

No response

[jeertmans]

Did you check the option --next-terminates-loop?

This might not be the exact thing you are looking for, but can you check?

[mateuszdrwal]

Yes, this seems to be the functionality I have been looking for! I didn't find it in the docs because I didn't expect it to be a command line parameter, but a property that you can apply to certain slides. Unfortunately, I am currently stuck with the web presenter as i suffer from #293 and my system python is 3.12, which pyside6 6.5 does not support. My workaround is probably going to be hacking together some GUI-supporting docker environment where I can run the QT presenter.

I'll let the issue stay open as this would be nice to have supported in the web presenter if the framework allows. Also, I think it would still be preferable to specify this behavior in code per slide since some looping slides may be longer and should always be skipped, although pressing the forward button twice is not a hard workaround.

[jeertmans]

Ok, well, I think this is a duplicate of #254, that I closed when implementing --next-terminates-loop. The issue is that I do not control how videos are played with RevealJS (HTML export), so the only way to support such a feature with HTML would be to hack the RevealJS code (or inject some hooks). This is totally feasible, but I don't feed I have the time nor the competence to implement this at the moment.

The reasons I implemented the --next-terminates-loop in a two-click solution was because I seemed to me the most natural and easy solution.

I will like this open in case someone has some time to help to improve either or both issues.

Regarding the issue with Python 3.12, I very easy workaround might be to install Python 3.11.

[mateuszdrwal]

I seem to have mistested the functionality last time, what I'm after is loop=True along with auto_next=True. This seems to work if I force both options to true in the presentation json file, but there is an old validation check from before #299 that prevents it from being specified in the slide python:

manim-slides/manim_slides/config.py

Lines 265 to 278 in 9460f6b

	@model_validator(mode="after")
	@classmethod
	def loop_and_auto_next_disallowed(
	cls, pre_slide_config: "PreSlideConfig"
	) -> "PreSlideConfig":
	if pre_slide_config.loop and pre_slide_config.auto_next:
	raise ValueError(
	"You cannot have both `loop=True` and `auto_next=True`, "
	"because a looping slide has no ending. "
	"This may be supported in the future if "
	"https://github.com/jeertmans/manim-slides/pull/299 gets merged."
	)
	return pre_slide_config

I'm not very familiar with the codebase, do you think there is anything else that may break if this check is removed?

[jeertmans]

I seem to have mistested the functionality last time, what I'm after is loop=True along with auto_next=True. This seems to work if I force both options to true in the presentation json file, but there is an old validation check from before #299 that prevents it from being specified in the slide python:

manim-slides/manim_slides/config.py

Lines 265 to 278 in 9460f6b

	@model_validator(mode="after")
	@classmethod
	def loop_and_auto_next_disallowed(
	cls, pre_slide_config: "PreSlideConfig"
	) -> "PreSlideConfig":
	if pre_slide_config.loop and pre_slide_config.auto_next:
	raise ValueError(
	"You cannot have both `loop=True` and `auto_next=True`, "
	"because a looping slide has no ending. "
	"This may be supported in the future if "
	"https://github.com/jeertmans/manim-slides/pull/299 gets merged."
	)
	return pre_slide_config

I'm not very familiar with the codebase, do you think there is anything else that may break if this check is removed?

Nice catch! Maybe you can do a PR that just removes this check?