Skip to content

[Bug]: The filter is not working #3397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 3 tasks
Rina1555 opened this issue Apr 17, 2025 · 12 comments
Open
1 of 3 tasks

[Bug]: The filter is not working #3397

Rina1555 opened this issue Apr 17, 2025 · 12 comments
Assignees
Labels
Bug: High Bugs that are negatively affecting the area of the program, but don't need immediate fix. OS: Linux / Flatpak OS: Windows 10

Comments

@Rina1555
Copy link

JASP Version

0.19.3

Commit ID

No response

JASP Module

Other

What analysis are you seeing the problem on?

filter

What OS are you seeing the problem on?

Windows 10

Bug Description

I've been trying for over an hour without success to apply a filter. I want to use only two levels from a variable that has four levels. When I uncheck the filter option for these levels in the Label Editor, the corresponding cases in the dataset do not turn grey. When I go to the general filter, it shows at the top of the row that the filter has been generated, but the filter still doesn't work. If I try to create a filter manually and apply it, there’s no error message, but the filter still doesn’t become active. I'm using Windows, and JASP is up to date. I’ve also tried reopening the program, but that didn’t help either. What could be the issue or what should I do? I'm a beginner with JASP, but I've followed instructions from online videos.

Expected Behaviour

The cases with the levels I don't want to use should be excluded from the analyses with this variable (or be greyed out).

Steps to Reproduce

  1. I double-click on the variable and then open the Label Editor. There, I deactivate the levels under 'Filter' that I don't want to include in the analyses (but it doesn't work).
  2. Since that doesn't work, I'm trying it via the filter condition: variable == 1 | variable == 2 (but that doesn't work either).

Log (if any)

No response

More Debug Information

-------- Application Info --------
JASP Version: JASP 0.19.3
Build Branch: 0.19.3
Build Date: Jan 3 2025 12:53:34 (Netherlands)
Last Commit: c8710df5442149527b0692cc1367ea5b3c982d04

-------- Basic Info --------
Operating System: Windows 10 Version 22H2
Product Version: 10
Kernel Type: winnt
Kernel Version: 10.0.19045
Architecture: x86_64
Install Path: C:/Program Files (x86)/JASP
Platfotm Name: windows
System Local: de_DE

-------- Extra Info --------
Current code page
Aktive Codepage: 850.
Aktive Codepage: 65001.

Final Checklist

  • I have included a screenshot showcasing the issue, if possible.
  • I have included a JASP file (zipped) or data file that causes the crash/bug, if applicable.
  • I have accurately described the bug, and steps to reproduce it.
@Rina1555 Rina1555 added the Bug label Apr 17, 2025
Copy link

@Rina1555, thanks for taking the time to create this issue. If possible (and applicable), please upload to the issue website (#3397, attaching to an email does not work) a screenshot showcasing the problem, and/or a compressed (zipped) .jasp file or the data file that causes the issue. If you would prefer not to make your data publicly available, you can send your file(s) directly to us, [email protected]

@github-actions github-actions bot added the Waiting for requester If waiting for a long time it is reasonable to close an issue label Apr 17, 2025
@shun2wang
Copy link
Contributor

Hi @Rina1555 Could you record your action on screen? We didn't know what you did now so cannot find out how to help you.

@tomtomme tomtomme reopened this Apr 18, 2025
@tomtomme
Copy link
Member

@Rina1555
Yesterday I had a similar issue on linux. But closing and re-opening JASP there helped. I used data from the data library only, but before the error appeared I played around with missings, added labels etc. So something I did before created a situation at which point the filter did not work and I had to reload the unmanipulated data set to get the filter to work. I will try to get a reproducible path.
If this is data related it would be good if you also could upload your zipped jasp file here.
thx

@Rina1555
Copy link
Author

Okay, so I tried it again with the raw dataset, and it clearly still works there. So I must have done something that caused the problem. However, I’m not sure when exactly I might have done something wrong. Since I’m a beginner, I experimented a lot, but I actually deleted everything that didn’t work.
I also noticed that JASP responds a bit slowly with my edited dataset. That’s not the case with the raw data. Could this be due to the analyses I’ve already performed? I also saw that in the top line of the filter section, it usually just says generatedFilter <- rep(TRUE, rowcount) — that’s what shows up at the top again in the raw dataset after I deactivate all variable filters, so that seems to be the default.
But in my problematic dataset, it does not say generatedFilter <- rep(TRUE, rowcount) after I deactivate all variable filters — instead, it says generatedFilter <- ((Geschlecht == '1') & (Geschlecht == '2')). So I think that might be the error I accidentally created at some point. I just don’t know how to fix it, since I’ve already tried to undo everything.
Do I really have to completely reprocess the entire dataset? That would be a lot of work… I’ve attached a screenshot to show you what I mean.
I prefer not to upload my JASP file here, if possible.

Image

@github-actions github-actions bot removed the Waiting for requester If waiting for a long time it is reasonable to close an issue label Apr 18, 2025
@JorisGoosen
Copy link
Contributor

Ai, that looks like a bug alright!

No need to reprocess the whole dataset though.
Just replace in the below code window put generatedFilter <- rep(TRUE, rowcount) above the line with generatedFilter.

We will try later to reproduce your problem and see if we still need to fix it.
I have made a bunch of changes to how the labels work for the upcoming release so with a bit of luck this is already fixed in the latest nightlies.

@Rina1555
Copy link
Author

I tried it, but it doesn’t work or change anything. I can only insert generatedFilter <- rep(TRUE, rowcount) in one place — I can’t edit the very top. In the screenshot you can see where I inserted it, but it didn’t make a difference. When I open the dataset, the filter at the top still says generatedFilter <- rep(TRUE, rowcount) at first. But as soon as I try to filter a level in the variable, the filter changes again to what I showed in the previous screenshot.

Image

@JorisGoosen
Copy link
Contributor

@Rina1555 can you attach the jaspfile here?

And could you upload the logs?

@JorisGoosen JorisGoosen added the Waiting for requester If waiting for a long time it is reasonable to close an issue label Apr 18, 2025
@Rina1555
Copy link
Author

I’d prefer not to upload the JASP file publicly. Earlier, I was given the following email address in case I didn’t want to upload it here: [email protected]. Would that work? Unfortunately, I haven’t created any logs so far.

@github-actions github-actions bot removed the Waiting for requester If waiting for a long time it is reasonable to close an issue label Apr 18, 2025
@JorisGoosen
Copy link
Contributor

That would be perfect.

And if you turn logging on now and simply reset the filter and tried it again it should go wrong again right?
Then I could see those logs.

@Rina1555
Copy link
Author

I´ve sent it via mail now :)

@tomtomme
Copy link
Member

tomtomme commented Apr 18, 2025

I have tried to reproduce my similar error from yesterday.
Yesterday, on my laptop,I did a lot of data editing before trying to set a filter. I also noticed that JASPs GUI was slowing down a bit. Maybe the filter worked, but I did not wait long enough until the rows would turn gray?
Because today on my way faster machine at home, I did a lot of data editing too, then set the filter and it needed like 10 seconds before the GUI would show that the filter was actually set.

@Rina1555
So maybe that is the solution for you? Set the filter and wait very long - depending of the size or your data and the amount of pre-editing stuff done.

But it could also be that my issue is totally different.

@Rina1555
Copy link
Author

@tomtomme Thank you for the tipp. But i don´t think that´s the problem. I also noticed that i needed to wait a while for some operations to work, but unfortunately that´s not the case for the filter. It didn´t change, even after several minutes.

@tomtomme tomtomme added Bug: High Bugs that are negatively affecting the area of the program, but don't need immediate fix. and removed Bug labels Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: High Bugs that are negatively affecting the area of the program, but don't need immediate fix. OS: Linux / Flatpak OS: Windows 10
Projects
None yet
Development

No branches or pull requests

5 participants