About workflows and pipelines

[bhaumikmaan]

ISSUE

I am working on this PR #49 to automate pipelines for code scanning and clean up

Features:

1. Code scanning with CodeQL
2. CI Pipeline that checks compile errors, lints and type checks

Opinion

As of now we have a bit of technical debt due to which the CI will always fail in lint and type-check which is why I have added continue-on-error: true to both of those to make the workflows work.

My question here is:
Should we merge with the ignoring of these failures? And work on it in parallel without the tests failing
OR
Should we not ignore them, let everyone's pipeline fail as a reminder and fix the technical debt as we go?

Need opinions on this.

[bhaumikmaan]

@Ornithopter-pilot @dev-opsss @us1415 @anshuman018
need your 2 cents

[anshuman018]

Temporarily allow failures using continue-on-error: true but only in a dedicated cleanup branch or specific PRs — not in main.

Create issues for each category of failure and track them clearly.

Set a short-term goal or milestone to fix all the failing checks and then enforce strict CI again.

While this temporary allowance is in place, make sure the failures are still visible in logs or summaries so contributors stay aware and can optionally help fix them.

[bhaumikmaan]

Temporarily allow failures using continue-on-error: true but only in a dedicated cleanup branch or specific PRs — not in main.

Create issues for each category of failure and track them clearly.

Set a short-term goal or milestone to fix all the failing checks and then enforce strict CI again.

While this temporary allowance is in place, make sure the failures are still visible in logs or summaries so contributors stay aware and can optionally help fix them.

Hey man, I would really appreciate your genuine opinions and not AI generated answer (have been noticing for a while and thought to say it out loud, sorry not sorry)

[us1415]

Agree with @anshuman018 . We should at the very least open issues for failing pipelines so we could correct them as time permits.

[bhaumikmaan]

Sounds like a plan.
Let's go ahead with the merging with continue-on-error: true removed.
Issues raised for each failing check for people to contribute to fixing.
@Ornithopter-pilot @dev-opsss Closing the issue but would still love to know your opinions and comments

[Ornithopter-pilot]

@bhaumikmaan @us1415 @anshuman018

Sorry guys, I got my hands in a lot of things, so didn't have enough time to reply right away... hope you understand.

Hmm, I'm seeing you decided to ditch the continue-on-error flags right away. Gotta be honest with you guys ... that's prob gonna cause some headaches.
Look, I've been down this road before with other projects. When you flip CI to strict mode overnight, you end up with a ton of broken PRs and frustrated contributors who can't get anything merged.

...
What works WAY better is:

Keep continue-on-error: true for now (just for a few weeks)
Create some tickets for the common failures we're seeing
Maybe add a quick project board called "Fix Our CI Debt" or something
Set a date (like end of month?) when we'll flip the switch

This way we get the pipelines running immediately + visibility into issues, but don't block everyone while we fix the baseline problems.

Most open source projects I've managed hit this exact same issue. Trust me, going gradual here saves everyone frustration, especially new contributors who'll just bounce if their PRs keep failing for existing issues.

What do y'all think? We can add a note in the workflows about when we plan to remove the flags.

[bhaumikmaan]

Sounds like a W plan to me. Really solid backing.

Trust me, going gradual here saves everyone frustration, especially new contributors who'll just bounce if their PRs keep failing for existing issues.

it's my first here so yes I'm inexperienced here hence your opinion mattered

[us1415]

I didnt see that we did that. I thought we opted for leave the continue on error on for now. If we didnt we should. I had to go re-read @anshuman018 's post and realized that he said to only keep it on for all other branches. We should keep it on in main until the fix is in place otherwise we will have a support nightmare on our hands.

[bhaumikmaan]

Cool so I'll go ahead and do the below things tomorrow i.e.

1. Keep the flags on and move ahead with the PR. Merge it tomorrow morning myself (@Ornithopter-pilot approve as draft/approve and then draft again please)
2. @Ornithopter-pilot again, if you could create a project for us
3. Raise necessary issues

[Ornithopter-pilot]

Sounds like a W plan to me. Really solid backing.

Trust me, going gradual here saves everyone frustration, especially new contributors who'll just bounce if their PRs keep failing for existing issues.

it's my first here so yes I'm inexperienced here hence your opinion mattered

No issues @bhaumikmaan , if you need any details on how we can implement this phased approach we can deepdive.. i just wanted to give you my 2 cents as i saw the decision you guys made was kinda bad . anyway , tag me if anything needed .. much love to you guys