FRR SRv6 test still passes when replacing P-node core with EOS (no SRv6)

[jbemmel]

netlab/tests/integration/srv6/02-isis-ipv4-bgp-vpn.yml

Line 49 in d27b18e

module: [ isis, srv6 ]

When I remove the srv6 module and replace the node device with eos, the test still passes on my machine. The packets are IPv6-encapped IPv4 ICMP packets

[ipspace]

Of course, that's how SRv6 works. It's all IPv6 for the intermediate nodes.

[jbemmel]

Right - so I think the test case should not include the SRv6 module there, as it restricts the set of possible devices one could have in that role

[ipspace]

In theory, you're correct. In practice, how does that matter?

[jbemmel]

To a person trying to learn about networking and SRv6 in particular, it puts them on the wrong mental track in terms of forming a hypothesis around how things work. Having ‘srv6’ there might make them think IS-IS is somehow passing some magical TLVs

[ipspace]

Ah, that hypothetical persona. I wonder why we never hear from them...

[ipspace]

Removed srv6 module from the core routers in integration tests by popular demand

[jbemmel]

A small PR for a man…

Thank you, appreciated