Discover and return Analyzer packages on project load

[TheAngryByrd]

Is your feature request related to a problem? Please describe.

Ionide/FsAutocomplete doesn't really support the FSharp.Analyzers from nuget packages.

Currently if you want to utilize the analyzers per package, you have to know a bit of magic up front:

https://ionide.io/FSharp.Analyzers.SDK/content/getting-started/MSBuild.html#Configuring-the-Build-Target

For example, $(PkgG-Research_FSharp_Analyzers)/analyzers/dotnet/fs will get you the path produced.

Describe the solution you'd like

We should see if we can return a list of these analyzers dlls per project on project load or some other mechanism.

Describe alternatives you've considered

Letting the users suffer.

Additional context
Add any other context or screenshots about the feature request here.

[baronfel]

There's some stuff in the SDK already about resolving analyzers from packages that follow the format:

<root>/analyzers/dotnet/<language><version>

And that's the responsibility of the 'analyzer resolver' in the sdk: https://github.com/dotnet/sdk/blob/4a7b8ec14c68b87dd609c9991480f31f4a6e5a24/src/Tasks/Microsoft.NET.Build.Tasks/ResolvePackageAssets.cs#L917-L935

However, we'd need to modify some of the helper functions to recognize F# before this would start lighting up, and also maybe change some things in the F# targets themselves. (A quick look through the SDK targets suggests this would just start working though - the Analyzer MSbuild Item would start getting populated for F# projects).

[TheAngryByrd]

There's some stuff in the SDK already about resolving analyzers from packages that follow the format:

<root>/analyzers/dotnet/<language><version>

And that's the responsibility of the 'analyzer resolver' in the sdk: https://github.com/dotnet/sdk/blob/4a7b8ec14c68b87dd609c9991480f31f4a6e5a24/src/Tasks/Microsoft.NET.Build.Tasks/ResolvePackageAssets.cs#L917-L935

Luckily we do follow that somewhat. We don't use the version currently.

However, we'd need to modify some of the helper functions to recognize F# before this would start lighting up, and also maybe change some things in the F# targets themselves. (A quick look through the SDK targets suggests this would just start working though - the Analyzer MSbuild Item would start getting populated for F# projects).

I do worry that we wouldn't be able to make a dent here. Since this is a community drive project and not coming from the F# core team, I have doubts we'd be considered. Also this means we'd have to wait for a specific SDK to make it available rather than being able to make it available sooner.

[baronfel]

I do worry that we wouldn't be able to make a dent here. Since this is a community drive project and not coming from the F# core team, I have doubts we'd be considered.

That's not likely to be a problem TBH - especially because the NuGet team is also doing work in this space soon: NuGet/Home#14455. If this goes in then I'd expect language-aware analyzer detection to just....start working?

Also this means we'd have to wait for a specific SDK to make it available rather than being able to make it available sooner.

This is true, but the second-best time to start, etc etc. If the SDK team can get the bootstrapper/updater out, we could help push SDK adoption faster - independently of the runtimes people target.

[TheAngryByrd]

@baronfel I created a fork/branch with some basic detection: TheAngryByrd/dotnet-sdk@08cde9f

Questions:

• Does this look like a good enough start or are there other things I should really consider?
• Do I need to create an issue/some design discussion first before submitting this PR?
• In either case, I'd appreciate help selling this as something the SDK should take.

[baronfel]

Commented on the PR - you're basically halfway there already. Can you log an SDK issue saying "F# projects should support processing Analyzers" with basically the same content as there is in this issue and link your branch/draft PR to it? This should all be pretty mechanical and not need much in the way of design work for the SDK team itself - all of the actual work is on the part of the F# team and community to define what the api compatibility should be like for these analyzers.

[TheAngryByrd]

Done: dotnet/sdk#51133