Add an overrideable way to name the load balancers so that multiple DSS can be deployed in one VPC

Set old values for new configurable vars to be default, moved documentation into schema file

Author: StevenPG

deploy/services/helm-charts/dss/templates/cockroachdb-loadbalancers.yaml

@@ -1,4 +1,5 @@
 {{- $cloudProvider := $.Values.global.cloudProvider}}
+{{- $cockroachDbLoadbalancerName := default "cockroach-db-external-node" $.Values.cockroachdb.conf.cockroachDbLoadbalancerName }}
 
 {{- if $.Values.cockroachdb.enabled }}
 
@@ -12,7 +13,7 @@ metadata:
     service.alpha.kubernetes.io/tolerate-unready-endpoints: "true"
     {{- include (printf "%s-lb-crdb-annotations" $cloudProvider)
       (dict
-        "name" (printf "%s-%s" "cockroach-db-external-node" ( $i | toString) )
+        "name" ($cockroachDbLoadbalancerName | trunc 31)
         "ip" $lb.ip
         "subnet" $lb.subnet
         "cloudProvider" $cloudProvider

deploy/services/helm-charts/dss/templates/dss-ingress-aws.yaml

@@ -1,4 +1,5 @@
 {{- $cloudProvider := $.Values.global.cloudProvider}}
+{{- $gatewayId := default "dss-gateway-external" $.Values.dss.gatewayId }}
 {{- if eq $cloudProvider "aws" }}
 {{/*
 AWS application load balancer Ingress do not support elastic ip assignment yet. Therefore, the
@@ -13,7 +14,7 @@ metadata:
     {{- include (printf "%s-ingress-dss-gateway-annotations" $cloudProvider)
       (merge .
         (dict
-          "name" "dss-gateway-external"
+          "name" ($gatewayId | trunc 63)
           "cloudProvider" $cloudProvider
         )
       ) | nindent 4

deploy/services/helm-charts/dss/values.schema.json

@@ -35,6 +35,10 @@
               "description": "Name of CockroachDB cluster",
               "type": "string"
             },
+            "cockroachDbLoadbalancerName": {
+              "description": "In AWS, used to name the load balancer. This must be overridden to run multiple DSS instances in a single region.",
+              "type": "string"
+            },
             "join": {
               "description": "List of already-existing CockroachDB instances. If empty, the chart will automatically discover the internal nodes. If set to join a DSS Region and other DSS instance, please add the addresses of the statefulset's pod as well.",
               "type": "array",
@@ -155,6 +159,10 @@
           "type": "string",
           "description": "Image of the DSS. Please note that the usage of the `latest` tag is discouraged to prevent accidental upgrades in case of restart. Example: `docker.io/interuss/dss:v0.15.0`. Official image releases: https://hub.docker.com/r/interuss/dss/tags"
         },
+        "gatewayId": {
+          "type": "string",
+          "description": "Unique identifier of the DSS Gateway. In AWS, this is used to name the load balancer and must be overridden to run multiple DSS instances in a single region."
+        },
         "conf": {
           "type": "object",
           "properties": {