[UR] fix coverity issues (#19817)

Author: pbalcer

unified-runtime/source/adapters/level_zero/enqueued_pool.hpp

@@ -35,7 +35,8 @@ class EnqueuedPool {
 
   EnqueuedPool(event_release_callback_t EventReleaseFn,
                memory_free_callback_t MemFreeFn)
-      : EventReleaseFn(EventReleaseFn), MemFreeFn(MemFreeFn) {}
+      : EventReleaseFn(std::move(EventReleaseFn)),
+        MemFreeFn(std::move(MemFreeFn)) {}
 
   ~EnqueuedPool();
   std::optional<Allocation> getBestFit(size_t Size, size_t Alignment,

unified-runtime/source/loader/layers/sanitizer/msan/msan_shadow.cpp

@@ -88,12 +88,9 @@ ur_result_t MsanShadowMemoryCPU::Setup() {
       uptr End = kMemoryLayout[i].end;
       uptr Size = End - Start;
       MappingDesc::Type Type = kMemoryLayout[i].type;
-      bool InitOrigins = true;
 
-      bool IsMap = Type == MappingDesc::SHADOW ||
-                   (InitOrigins && Type == MappingDesc::ORIGIN);
-      bool IsProtect = Type == MappingDesc::INVALID ||
-                       (!InitOrigins && Type == MappingDesc::ORIGIN);
+      bool IsMap = Type == MappingDesc::SHADOW || Type == MappingDesc::ORIGIN;
+      bool IsProtect = Type == MappingDesc::INVALID;
 
       if (IsMap) {
         if (MmapFixedNoReserve(Start, Size) == 0) {
@@ -124,9 +121,7 @@ ur_result_t MsanShadowMemoryCPU::Destory() {
       uptr End = kMemoryLayout[i].end;
       uptr Size = End - Start;
       MappingDesc::Type Type = kMemoryLayout[i].type;
-      bool InitOrigins = true;
-      bool IsMap = Type == MappingDesc::SHADOW ||
-                   (InitOrigins && Type == MappingDesc::ORIGIN);
+      bool IsMap = Type == MappingDesc::SHADOW || Type == MappingDesc::ORIGIN;
       if (IsMap) {
         if (Munmap(Start, Size)) {
           return UR_RESULT_ERROR_UNKNOWN;

unified-runtime/source/loader/ur_lib.cpp

@@ -648,10 +648,15 @@ ur_result_t urDeviceGetSelected(ur_platform_handle_t hPlatform,
                    [&](ur_device_handle_t urDeviceHandle) {
                      // obtain and record device type from platform (squash
                      // errors)
-                     ur_device_type_t hardwareType = ::UR_DEVICE_TYPE_DEFAULT;
-                     urDeviceGetInfo(urDeviceHandle, UR_DEVICE_INFO_TYPE,
-                                     sizeof(ur_device_type_t), &hardwareType,
-                                     0);
+                     ur_device_type_t hardwareType;
+                     ur_result_t res = urDeviceGetInfo(
+                         urDeviceHandle, UR_DEVICE_INFO_TYPE,
+                         sizeof(ur_device_type_t), &hardwareType, 0);
+                     // ignore failures and just assume the default hw type
+                     if (res != UR_RESULT_SUCCESS) {
+                       hardwareType = ::UR_DEVICE_TYPE_DEFAULT;
+                     }
+
                      return DeviceSpec{DevicePartLevel::ROOT, hardwareType,
                                        deviceCount++,         DeviceIdTypeALL,
                                        DeviceIdTypeALL,       urDeviceHandle};