meta-refkit-extra: Yocto compatible

The yocto-compat-layer.py tool checks whether a layer follows the
"Yocto Compatible 2.0" guidelines. We want to comply, so now
meta-refkit-extra gets tested by the tool via a selftest defined in
meta-refkit.

The selftest has to be defined there, otherwise it would not be found
via oe-selftest as meta-refkit-extra isn't enabled in our normal CI
builds. That is suitable for the yocto-compat-layer.py tool, because it
is designed to test layers that are not already enabled.

The only problem found by the tool is the missing README in the top
directory. This is addressed (at least as far as the automated check
is concerned) by moving the README from the doc directory. However, we
probably also lack some information commonly expected in the file
itself.

Signed-off-by: Patrick Ohly <[email protected]>

Author: pohly

meta-refkit-extra/doc/README renamed to meta-refkit-extra/README

@@ -53,7 +53,7 @@ REFKIT_VM_IMAGE_TYPES = "wic.xz wic.zip wic.bmap wic.xz.sha256sum"
 # pre/post-build oe-selftests started by CI builder, whitespace-separated.
 #
 REFKIT_CI_PREBUILD_SELFTESTS="iotsstatetests.SStateTests.test_sstate_samesigs"
-REFKIT_CI_POSTBUILD_SELFTESTS="image-installer"
+REFKIT_CI_POSTBUILD_SELFTESTS="image-installer meta-refkit-extra"
 #
 # Automated build targets
 # Those targets should be space separated list of items,

meta-refkit/conf/distro/include/refkit-ci.inc

@@ -0,0 +1,59 @@
+#!/usr/bin/env python
+# ex:ts=4:sw=4:sts=4:et
+# -*- tab-width: 4; c-basic-offset: 4; indent-tabs-mode: nil -*-
+#
+# Copyright (c) 2017, Intel Corporation.
+# All rights reserved.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 2 as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+#
+# AUTHORS
+# Patrick Ohly <[email protected]>
+
+"""
+Test cases that verify certain aspects of meta-refkit-extra
+in relation to meta-refkit. They need to be here because
+meta-refkit-extra is not enabled by default and thus
+tests defined there wouldn't be found.
+"""
+
+import re
+
+from oeqa.selftest.base import oeSelfTest
+from oeqa.utils.commands import runCmd, bitbake, get_bb_var
+
+class MetaRefkitExtra(oeSelfTest):
+    """
+    These tests must run in a build configuration that does *not* have
+    meta-refkit-extra.
+    """
+
+    def setUpLocal(self):
+        """
+        This code is executed before each test method.
+        It verifies that meta-refkit-extra is not active.
+        """
+
+        result = runCmd('bitbake-layers show-layers')
+        for layer, path, pri in re.findall(r'^(\S+)\s+(.*?)\s+(\d+)$', result.output, re.MULTILINE):
+            if layer == 'meta-refkit-extra':
+                self.skipTest('meta-refkit-extra already in bblayers.conf')
+            if layer == 'meta-refkit':
+                self.refkit_extra_path = path + '/../meta-refkit-extra'
+
+    def test_yocto_compat(self):
+        """
+        Checks for 'Yocto Compatible 2.0' using the yocto-compat-layer.py tool.
+        """
+        runCmd("yocto-compat-layer.py '%s'" % self.refkit_extra_path)