Fixed HAX_VCPU_IOCTL_SET_MSRS access type

AlexAltea · AlexAltea · commit 49eb94f79559 · 2018-11-21T12:07:01.000+01:00
Signed-off-by: Alexandro Sanchez Bach &lt;asanchez@kryptoslogic.com&gt;
diff --git a/include/hax_interface.h b/include/hax_interface.h
@@ -157,7 +157,7 @@
 #define HAX_VCPU_IOCTL_GET_MSRS \
     HAX_IOCTL(HAX_IOWR, 0x06, struct hax_msr_data)
 #define HAX_VCPU_IOCTL_SET_MSRS \
-    HAX_IOCTL(HAX_IOW,  0x07, struct hax_msr_data)
+    HAX_IOCTL(HAX_IOWR, 0x07, struct hax_msr_data)
 #define HAX_VCPU_IOCTL_INTERRUPT \
     HAX_IOCTL(HAX_IOW,  0x08, uint32_t)
 #define HAX_VCPU_IOCTL_DEBUG \
diff --git a/platforms/linux/components.c b/platforms/linux/components.c
@@ -363,6 +363,10 @@ static long hax_vcpu_ioctl(struct file *filp, unsigned int cmd,
             }
         }
         msrs.done = i;
+        if (copy_to_user(argp, &msrs, sizeof(msrs))) {
+            ret = -EFAULT;
+            break;
+        }
         break;
     }
     case HAX_VCPU_IOCTL_GET_MSRS__LEGACY:

Original file line number	Diff line number	Diff line change
`@@ -363,6 +363,10 @@ static long hax_vcpu_ioctl(struct file *filp, unsigned int cmd,`
`363`	`363`	`}`
`364`	`364`	`}`
`365`	`365`	`msrs.done = i;`
	`366`	`+ if (copy_to_user(argp, &msrs, sizeof(msrs))) {`
	`367`	`+ ret = -EFAULT;`
	`368`	`+ break;`
	`369`	`+ }`
`366`	`370`	`break;`
`367`	`371`	`}`
`368`	`372`	`case HAX_VCPU_IOCTL_GET_MSRS__LEGACY:`