Merge pull request #279 from input-output-hk/more_ruff_checks

refactor: use max function for clarity

Author: mkoura

cardano_clusterlib/clusterlib_klass.py

@@ -368,7 +368,7 @@ def wait_for_slot(self, slot: int) -> int:
                 no_block_time = 0
 
             _sleep_time = slots_diff * self.slot_length
-            sleep_time = _sleep_time if _sleep_time > min_sleep else min_sleep
+            sleep_time = max(min_sleep, _sleep_time)
 
             if not printed and sleep_time > long_sleep:
                 LOGGER.info(f"Waiting for {sleep_time:.2f} sec for slot no {slot}.")

cardano_clusterlib/txtools.py

@@ -120,7 +120,7 @@ def _select_utxos(
                 utxo_ids.update(f"{rec.utxo_hash}#{rec.utxo_ix}" for rec in coin_txins)
                 continue
 
-            tx_fee = fee if fee > 1 else 1
+            tx_fee = max(1, fee)
             funds_needed = total_output_amount + tx_fee + deposit + treasury_donation
             total_withdrawals_amount = functools.reduce(lambda x, y: x + y.amount, withdrawals, 0)
             # Fee needs an input, even if withdrawal would cover all needed funds
@@ -188,7 +188,7 @@ def _balance_txouts(
                 max_address = coin_txouts.pop(max_index[0]).address
 
             total_output_amount = functools.reduce(lambda x, y: x + y.amount, coin_txouts, 0)
-            tx_fee = fee if fee > 0 else 0
+            tx_fee = max(0, fee)
             total_withdrawals_amount = functools.reduce(lambda x, y: x + y.amount, withdrawals, 0)
             funds_available = total_input_amount + total_withdrawals_amount
             funds_needed = total_output_amount + tx_fee + deposit + treasury_donation

docs/source/conf.py

@@ -92,7 +92,7 @@ def find_source():
         for part in info["fullname"].split("."):
             try:
                 obj = getattr(obj, part)
-            except Exception:
+            except Exception:  # noqa: PERF203
                 return None
 
         # strip decorators, which would resolve to the source of the decorator

pyproject.toml

@@ -43,7 +43,7 @@ force_single_line = true
 line-length = 100
 
 [tool.ruff.lint]
-select = ["ARG", "B", "C4", "C90", "D", "DTZ", "E", "EM", "F", "I001", "ISC", "N", "PIE", "PL", "PLE", "PLR", "PLW", "PT", "PTH", "Q", "RET", "RSE", "RUF", "SIM", "TRY", "UP", "W", "YTT"]
+select = ["ARG", "B", "C4", "C90", "D", "DTZ", "E", "EM", "F", "FURB", "I001", "ISC", "N", "PERF", "PIE", "PL", "PLE", "PLR", "PLW", "PT", "PTH", "Q", "RET", "RSE", "RUF", "SIM", "TRY", "UP", "W", "YTT"]
 ignore = ["D10", "D203", "D212", "D213", "D214", "D215", "D404", "D405", "D406", "D407", "D408", "D409", "D410", "D411", "D413", "ISC001", "PLR0912", "PLR0913", "PLR0915", "PT001", "PT007", "PT012", "PT018", "PT023", "PTH123", "RET504", "TRY002", "TRY301", "UP006", "UP007", "UP035"]
 
 [tool.ruff.lint.isort]