Skip LDAP group members with no uid attribute (#76)

Author: ThiefMaster

CHANGES.rst

@@ -1,6 +1,12 @@
 Changelog
 =========
 
+Version 0.5.3
+-------------
+
+- Skip LDAP group members that do not have the specified ``uid`` attribute set instead
+  of failing with an error
+
 Version 0.5.2
 -------------
 

flask_multipass/__init__.py

@@ -13,7 +13,7 @@
 from .identity import IdentityProvider
 
 
-__version__ = '0.5.2'
+__version__ = '0.5.3'
 __all__ = ('Multipass', 'AuthProvider', 'IdentityProvider', 'AuthInfo', 'IdentityInfo', 'Group', 'MultipassException',
            'AuthenticationFailed', 'IdentityRetrievalFailed', 'GroupRetrievalFailed', 'NoSuchUser',
            'InvalidCredentials')

flask_multipass/providers/ldap/providers.py

@@ -116,7 +116,12 @@ def get_members(self):
                 user_filter = build_user_search_filter({self.ldap_settings['member_of_attr']: {group_dn}}, exact=True)
                 for _, user_data in self.provider._search_users(user_filter):
                     user_data = to_unicode(user_data)
-                    yield IdentityInfo(self.provider, identifier=user_data[self.ldap_settings['uid']][0], **user_data)
+                    try:
+                        identifier = user_data[self.ldap_settings['uid']][0]
+                    except KeyError:
+                        # user does not have an identifier -> skip it
+                        continue
+                    yield IdentityInfo(self.provider, identifier=identifier, **user_data)
                 group_filter = build_group_search_filter({self.ldap_settings['member_of_attr']: {group_dn}}, exact=True)
                 subgroups = list(self.provider._search_groups(group_filter))
                 try: