From 6bb5673b926c1fbe6ffed0c331acb991c295342d Mon Sep 17 00:00:00 2001 From: Yoni Jah Date: Thu, 4 Dec 2014 13:33:57 +0800 Subject: [PATCH 1/2] name attribute support for input --- dist/amd/form/input.js | 3 ++- dist/cjs/form/input.js | 3 ++- dist/globals/main.js | 3 ++- dist/named-amd/main.js | 3 ++- lib/form/input.coffee | 3 ++- 5 files changed, 10 insertions(+), 5 deletions(-) diff --git a/dist/amd/form/input.js b/dist/amd/form/input.js index a28e529..fb7dbd8 100644 --- a/dist/amd/form/input.js +++ b/dist/amd/form/input.js @@ -15,11 +15,12 @@ define( InputComponent = FormGroupComponent.extend({ controlView: Em.TextField.extend(ControlMixin, { - attributeBindings: ['placeholder', 'required', 'autofocus', 'disabled'], + attributeBindings: ['placeholder', 'required', 'autofocus', 'disabled', 'name'], placeholder: Em.computed.alias('parentView.placeholder'), required: Em.computed.alias('parentView.required'), autofocus: Em.computed.alias('parentView.autofocus'), disabled: Em.computed.alias('parentView.disabled'), + name: Em.computed.alias('parentView.name'), type: Em.computed.alias('parentView.type'), model: Em.computed.alias('parentView.model'), propertyName: Em.computed.alias('parentView.propertyName') diff --git a/dist/cjs/form/input.js b/dist/cjs/form/input.js index 580841f..17b1a60 100644 --- a/dist/cjs/form/input.js +++ b/dist/cjs/form/input.js @@ -12,11 +12,12 @@ var InputComponent; InputComponent = FormGroupComponent.extend({ controlView: Em.TextField.extend(ControlMixin, { - attributeBindings: ['placeholder', 'required', 'autofocus', 'disabled'], + attributeBindings: ['placeholder', 'required', 'autofocus', 'disabled', 'name'], placeholder: Em.computed.alias('parentView.placeholder'), required: Em.computed.alias('parentView.required'), autofocus: Em.computed.alias('parentView.autofocus'), disabled: Em.computed.alias('parentView.disabled'), + name: Em.computed.alias('parentView.name'), type: Em.computed.alias('parentView.type'), model: Em.computed.alias('parentView.model'), propertyName: Em.computed.alias('parentView.propertyName') diff --git a/dist/globals/main.js b/dist/globals/main.js index ad5da3a..dba56af 100644 --- a/dist/globals/main.js +++ b/dist/globals/main.js @@ -290,11 +290,12 @@ var InputComponent; InputComponent = FormGroupComponent.extend({ controlView: Em.TextField.extend(ControlMixin, { - attributeBindings: ['placeholder', 'required', 'autofocus', 'disabled'], + attributeBindings: ['placeholder', 'required', 'autofocus', 'disabled', 'name'], placeholder: Em.computed.alias('parentView.placeholder'), required: Em.computed.alias('parentView.required'), autofocus: Em.computed.alias('parentView.autofocus'), disabled: Em.computed.alias('parentView.disabled'), + name: Em.computed.alias('parentView.name'), type: Em.computed.alias('parentView.type'), model: Em.computed.alias('parentView.model'), propertyName: Em.computed.alias('parentView.propertyName') diff --git a/dist/named-amd/main.js b/dist/named-amd/main.js index 0f41d08..d789a57 100644 --- a/dist/named-amd/main.js +++ b/dist/named-amd/main.js @@ -304,11 +304,12 @@ define("ember-forms/form/input", InputComponent = FormGroupComponent.extend({ controlView: Em.TextField.extend(ControlMixin, { - attributeBindings: ['placeholder', 'required', 'autofocus', 'disabled'], + attributeBindings: ['placeholder', 'required', 'autofocus', 'disabled', 'name'], placeholder: Em.computed.alias('parentView.placeholder'), required: Em.computed.alias('parentView.required'), autofocus: Em.computed.alias('parentView.autofocus'), disabled: Em.computed.alias('parentView.disabled'), + name: Em.computed.alias('parentView.name'), type: Em.computed.alias('parentView.type'), model: Em.computed.alias('parentView.model'), propertyName: Em.computed.alias('parentView.propertyName') diff --git a/lib/form/input.coffee b/lib/form/input.coffee index 65b87de..cb5b52e 100644 --- a/lib/form/input.coffee +++ b/lib/form/input.coffee @@ -9,11 +9,12 @@ Syntax: ### InputComponent = FormGroupComponent.extend( controlView: Em.TextField.extend(ControlMixin, - attributeBindings: ['placeholder', 'required', 'autofocus', 'disabled'] + attributeBindings: ['placeholder', 'required', 'autofocus', 'disabled', 'name'] placeholder: Em.computed.alias 'parentView.placeholder' required: Em.computed.alias 'parentView.required' autofocus: Em.computed.alias 'parentView.autofocus' disabled: Em.computed.alias 'parentView.disabled' + name: Em.computed.alias 'parentView.name' type: Em.computed.alias 'parentView.type' model: Em.computed.alias 'parentView.model' propertyName: Em.computed.alias 'parentView.propertyName' From 2655e0fc3e60792593a1f4c15741a955be06c09e Mon Sep 17 00:00:00 2001 From: Yoni Jah Date: Wed, 18 Feb 2015 16:28:43 +0800 Subject: [PATCH 2/2] Checkbox should not import itself --- addon/checkbox.js | 1 - 1 file changed, 1 deletion(-) diff --git a/addon/checkbox.js b/addon/checkbox.js index ccc0041..0f02ce5 100644 --- a/addon/checkbox.js +++ b/addon/checkbox.js @@ -1,6 +1,5 @@ import Em from 'ember'; import FormGroupComponent from './group'; -import FormCheckboxComponent from './checkbox'; import ControlMixin from 'ember-idx-forms/mixins/control'; /*