From 49706398e491414882d36ab5496dabe4c3e1d0f2 Mon Sep 17 00:00:00 2001
From: Abhilash Raju <abhilash.kollam@gmail.com>
Date: Wed, 10 Sep 2025 07:36:03 +0000
Subject: [PATCH] Fix 726312: Fix for pel registry missing

Signed-off-by: Abhilash Raju <abhilash.kollam@gmail.com>
---
 acfshell/README.md         | 13 ++++++++++---
 acfshell/script_runner.hpp | 11 ++++-------
 2 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/acfshell/README.md b/acfshell/README.md
index d58fc38..ad689e5 100644
--- a/acfshell/README.md
+++ b/acfshell/README.md
@@ -42,8 +42,6 @@ flowchart TD
  subgraph acfshell["acfshell"]
     direction TB
         M["Shell object"]
-        subgraph async["Async Script Execution"]
-          direction TB
             N["Script Object"]
             O["Script Runner"]
             P["Timer Task"]
@@ -51,8 +49,14 @@ flowchart TD
             R{"Dump Needed"}
             S["Clear Results"]
             T["Execute Dump"]
-        end
   end
+subgraph dumpmanager["dumpmanager"]
+    direction TB
+      A1["Dbug Collector"]
+            A2["PLDM"]
+            A3["PHYP"]
+        
+end
     A["Redfish Client"] -- Installs ACF file --> B["bmcweb"]
     B -- Invokes --> C
     C --> D
@@ -60,6 +64,9 @@ flowchart TD
     D -- Validation Success --> F
     F --> G
     G -- Resource Dump --> H
+    H -- Dump Dbus --> A1
+    A1 -- PLDM Dbus --> A2
+    A2 -- FileIO--> A3
     G -- bmcshell --> I
     G -- Service --> J
     G -- Admin Reset --> K
diff --git a/acfshell/script_runner.hpp b/acfshell/script_runner.hpp
index ab63daf..40d6ce9 100644
--- a/acfshell/script_runner.hpp
+++ b/acfshell/script_runner.hpp
@@ -270,9 +270,7 @@ struct ScriptRunner
     {
         try
         {
-            co_await createInfoLog(
-                std::format("Start executing script: {} with dump needed {}",
-                            filename, dumpNeeded));
+            co_await createInfoLog("xyz.openbmc_project.acfshell.ShellStarted");
 
             bp::async_pipe ap(io_context);
             bp::async_pipe ep(io_context);
@@ -300,13 +298,12 @@ struct ScriptRunner
                            c.exit_code())
                     << std::endl;
                 co_await createInfoLog(
-                    std::format("Script execution cancelled"
-                                " for script: {}, exited with code {}",
-                                hash, c.exit_code()));
+                    "xyz.openbmc_project.acfshell.ShellCancelled");
             }
             else
             {
-                co_await createInfoLog("Script execution Finished");
+                co_await createInfoLog(
+                    "xyz.openbmc_project.acfshell.Completed");
             }
             ofs.close();
             if (dumpNeeded)