fixup issues with variable names

Author: rbinns

root-applications/ibm-mas-cluster-root/templates/065-sls-appset.yaml

@@ -10,8 +10,8 @@ metadata:
     environment: '{{ .Values.account.id }}'
     region: '{{ .Values.region.id }}'
     cluster: '{{ .Values.cluster.id }}'
-    icn: '{{ .Values.ibm-customer-number }}'
-    subscription-id: '{{ .Values.sls-subscription-id }}'
+    icn: '{{ .Values.ibm_customer_number }}'
+    subscription_id: '{{ .Values.subscription_id }}'
   annotations:
     argocd.argoproj.io/sync-wave: "065"
 spec:
@@ -39,8 +39,8 @@ spec:
         environment: '{{ .Values.account.id }}'
         region: '{{ .Values.region.id }}'
         cluster: '{{ .Values.cluster.id }}'
-        icn: '{{ `{{.instance.}}` }}'   <<--- 
-        saas-sub-id: '{{ `{{.instance.saas-sub-id}}` }}'
+        icn: '{{ `{{.instance.ibm_customer_number}}` }}'
+        saas-sub-id: '{{ `{{.instance.subscription_id}}` }}'
 {{- if .Values.custom_labels }}
 {{ .Values.custom_labels | toYaml | indent 8 }}
 {{- end }}