Skip to content

s/data-attach-point/attach-point/g, fixes #175. #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

s/data-attach-point/attach-point/g, fixes #175. #176

wants to merge 1 commit into from

Conversation

@asudoh
Copy link
Contributor

@asudoh asudoh commented Apr 21, 2016

No description provided.

@wkeese
Copy link
Member

wkeese commented Apr 21, 2016

Note that delite can actually handle both attach-point and data-attach-point.

attach-point is more convenient to type and IIRC matches how Polymer works. So I guess everyone uses attach-point nowadays.

data-attach-point is for people who are pedantic about HTML verification. A few years ago it was very frowned upon to have attribute names that failed HTML verification, which is why the whole data-... attribute name thing was invented.

@asudoh
Copy link
Contributor Author

asudoh commented May 2, 2016

Thank you very much @wkeese for the history. Made a change to support both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asudoh @wkeese