IBX-9727: [Tests] Aligned Forms transformers tests with generics fixes

Author: alongosz

tests/lib/FieldType/DataTransformer/MultiSelectionValueTransformerTest.php

@@ -14,19 +14,22 @@
 
 class MultiSelectionValueTransformerTest extends TestCase
 {
+    /**
+     * @phpstan-return list<array{array<int>}>
+     */
     public function transformProvider(): array
     {
         return [
             [[0]],
-            [['null']],
             [[1, 2]],
-            [['forty', 'two']],
             [[1, 4, 1, 5, 9, 2, 6]],
         ];
     }
 
     /**
      * @dataProvider transformProvider
+     *
+     * @param array<int> $valueAsArray
      */
     public function testTransform(array $valueAsArray): void
     {
@@ -37,6 +40,8 @@ public function testTransform(array $valueAsArray): void
 
     /**
      * @dataProvider transformProvider
+     *
+     * @param array<int> $valueAsArray
      */
     public function testReverseTransform(array $valueAsArray): void
     {
@@ -45,6 +50,9 @@ public function testReverseTransform(array $valueAsArray): void
         self::assertEquals($expectedValue, $transformer->reverseTransform($valueAsArray));
     }
 
+    /**
+     * @phpstan-return list<array{mixed}>
+     */
     public function transformNullProvider(): array
     {
         return [

tests/lib/FieldType/DataTransformer/MultipleCountryValueTransformerTest.php

@@ -12,12 +12,17 @@
 use Ibexa\Core\FieldType\Country\Value;
 use PHPUnit\Framework\TestCase;
 
-class MultipleCountryValueTransformerTest extends TestCase
+/**
+ * @phpstan-import-type TCountryValueData from \Ibexa\ContentForms\FieldType\DataTransformer\MultipleCountryValueTransformer
+ */
+final class MultipleCountryValueTransformerTest extends TestCase
 {
     /**
-     * @var array Array of countries from "ibexa.field_type.country.data"
+     * Array of countries from "ibexa.field_type.country.data".
+     *
+     * @phpstan-var array<string, TCountryValueData>
      */
-    protected $countriesInfo = [
+    protected array $countriesInfo = [
         'AF' => ['Name' => 'Afghanistan', 'Alpha2' => 'AF', 'Alpha3' => 'AFG', 'IDC' => '93'],
         'AX' => ['Name' => 'Åland', 'Alpha2' => 'AX', 'Alpha3' => 'ALA', 'IDC' => '358'],
         'AQ' => ['Name' => 'Antarctica', 'Alpha2' => 'AQ', 'Alpha3' => 'ATA', 'IDC' => '672'],
@@ -44,22 +49,31 @@ class MultipleCountryValueTransformerTest extends TestCase
         'ZW' => ['Name' => 'Zimbabwe', 'Alpha2' => 'ZW', 'Alpha3' => 'ZWE', 'IDC' => '263'],
     ];
 
+    /**
+     * @phpstan-return list<array{array<string, TCountryValueData>}>
+     */
     public function transformProvider(): array
     {
         return [
-            [[
-                  'BN' => ['Name' => 'Brunei Darussalam', 'Alpha2' => 'BN', 'Alpha3' => 'BRN', 'IDC' => '673'],
-              ]],
-            [[
-                  'AX' => ['Name' => 'Åland', 'Alpha2' => 'AX', 'Alpha3' => 'ALA', 'IDC' => '358'],
-                  'BL' => ['Name' => 'Saint Barthélemy', 'Alpha2' => 'BL', 'Alpha3' => 'BLM', 'IDC' => '590'],
-                  'GS' => ['Name' => 'South Georgia and The South Sandwich Islands', 'Alpha2' => 'GS', 'Alpha3' => 'SGS', 'IDC' => '500'],
-              ]],
+            [
+                [
+                    'BN' => ['Name' => 'Brunei Darussalam', 'Alpha2' => 'BN', 'Alpha3' => 'BRN', 'IDC' => '673'],
+                ],
+            ],
+            [
+                [
+                    'AX' => ['Name' => 'Åland', 'Alpha2' => 'AX', 'Alpha3' => 'ALA', 'IDC' => '358'],
+                    'BL' => ['Name' => 'Saint Barthélemy', 'Alpha2' => 'BL', 'Alpha3' => 'BLM', 'IDC' => '590'],
+                    'GS' => ['Name' => 'South Georgia and The South Sandwich Islands', 'Alpha2' => 'GS', 'Alpha3' => 'SGS', 'IDC' => '500'],
+                ],
+            ],
         ];
     }
 
     /**
      * @dataProvider transformProvider
+     *
+     * @phpstan-param array<string, TCountryValueData> $valueAsArray
      */
     public function testTransform(array $valueAsArray): void
     {
@@ -70,6 +84,8 @@ public function testTransform(array $valueAsArray): void
 
     /**
      * @dataProvider transformProvider
+     *
+     * @phpstan-param array<string, TCountryValueData> $valueAsArray
      */
     public function testReverseTransform(array $valueAsArray): void
     {
@@ -78,6 +94,9 @@ public function testReverseTransform(array $valueAsArray): void
         self::assertEquals($expectedValue, $transformer->reverseTransform(array_keys($valueAsArray)));
     }
 
+    /**
+     * @phpstan-return list<array{int|string|array<mixed>|null}>
+     */
     public function transformNullProvider(): array
     {
         return [
@@ -91,12 +110,15 @@ public function transformNullProvider(): array
     /**
      * @dataProvider transformNullProvider
      */
-    public function testTransformNull(int|string|array|null $value): void
+    public function testTransformNull(mixed $value): void
     {
         $transformer = new MultipleCountryValueTransformer($this->countriesInfo);
         self::assertNull($transformer->transform($value));
     }
 
+    /**
+     * @phpstan-return list<array{mixed}>
+     */
     public function reverseTransformNullProvider(): array
     {
         return [

tests/lib/FieldType/DataTransformer/SingleSelectionValueTransformerTest.php

@@ -14,6 +14,9 @@
 
 class SingleSelectionValueTransformerTest extends TestCase
 {
+    /**
+     * @phpstan-return list<array{int}>
+     */
     public function transformProvider(): array
     {
         return [
@@ -42,6 +45,9 @@ public function testReverseTransform(int $value): void
         self::assertEquals($expectedValue, $transformer->reverseTransform($value));
     }
 
+    /**
+     * @phpstan-return list<array{mixed}>
+     */
     public function transformNullProvider(): array
     {
         return [

tests/lib/FieldType/DataTransformer/TimeValueTransformerTest.php

@@ -47,6 +47,7 @@ public function testTransformInvalidValue(): void
         $transformer = new TimeValueTransformer();
 
         $this->expectException(TransformationFailedException::class);
+        /** @phpstan-ignore argument.type */
         $transformer->transform((object) ['time' => 1]);
     }
 }