IBX-9727: Added type-hints and adapted codebase to PHP8+ within contracts

Author: konradoboza

phpstan-baseline.neon

@@ -21,8 +21,8 @@ abstract class Controller extends AbstractController implements RestrictedContro
     public function redirectToLocation(Location $location, string $uriFragment = ''): RedirectResponse
     {
         return $this->redirectToRoute('ibexa.content.view', [
-            'contentId' => $location->contentId,
-            'locationId' => $location->id,
+            'contentId' => $location->getContentId(),
+            'locationId' => $location->getId(),
             '_fragment' => $uriFragment,
         ]);
     }

src/contracts/Controller/Controller.php

@@ -10,6 +10,5 @@
 
 final class AutosaveEvents
 {
-    /** @var string */
-    public const CONTENT_AUTOSAVE = 'content.edit.autosave';
+    public const string CONTENT_AUTOSAVE = 'content.edit.autosave';
 }

src/contracts/Event/AutosaveEvents.php

@@ -20,20 +20,11 @@ final class ContentEditEvent extends Event
 {
     private ?Response $response = null;
 
-    private Content $content;
-
-    private VersionInfo $versionInfo;
-
-    private string $languageCode;
-
     public function __construct(
-        Content $content,
-        VersionInfo $versionInfo,
-        string $languageCode
+        private readonly Content $content,
+        private readonly VersionInfo $versionInfo,
+        private readonly string $languageCode
     ) {
-        $this->content = $content;
-        $this->versionInfo = $versionInfo;
-        $this->languageCode = $languageCode;
     }
 
     public function getContent(): Content

src/contracts/Event/ContentEditEvent.php

@@ -8,17 +8,13 @@
 
 namespace Ibexa\Contracts\AdminUi\Event;
 
-final class ContentOnTheFlyEvents
+final readonly class ContentOnTheFlyEvents
 {
-    /** @var string */
-    public const CONTENT_CREATE = 'ibexa.content_on_the_fly.create';
+    public const string CONTENT_CREATE = 'ibexa.content_on_the_fly.create';
 
-    /** @var string */
-    public const CONTENT_CREATE_PUBLISH = 'ibexa.content_on_the_fly.create.publish';
+    public const string CONTENT_CREATE_PUBLISH = 'ibexa.content_on_the_fly.create.publish';
 
-    /** @var string */
-    public const CONTENT_EDIT = 'ibexa.content_on_the_fly.edit';
+    public const string CONTENT_EDIT = 'ibexa.content_on_the_fly.edit';
 
-    /** @var string */
-    public const CONTENT_EDIT_PUBLISH = 'ibexa.content_on_the_fly.edit.publish';
+    public const string CONTENT_EDIT_PUBLISH = 'ibexa.content_on_the_fly.edit.publish';
 }

src/contracts/Event/ContentOnTheFlyEvents.php

@@ -18,28 +18,19 @@
  */
 class ContentProxyCreateEvent extends Event
 {
-    public const OPTION_CONTENT_DRAFT = 'contentDraft';
-    public const OPTION_IS_ON_THE_FLY = 'isOnTheFly';
+    public const string OPTION_CONTENT_DRAFT = 'contentDraft';
+    public const string OPTION_IS_ON_THE_FLY = 'isOnTheFly';
 
     private ?Response $response = null;
 
-    private ContentType $contentType;
-
-    private string $languageCode;
-
-    private int $parentLocationId;
-
     private Options $options;
 
     public function __construct(
-        ContentType $contentType,
-        string $languageCode,
-        int $parentLocationId,
+        private readonly ContentType $contentType,
+        private readonly string $languageCode,
+        private readonly int $parentLocationId,
         ?Options $options = null
     ) {
-        $this->contentType = $contentType;
-        $this->languageCode = $languageCode;
-        $this->parentLocationId = $parentLocationId;
         $this->options = $options ?? new Options();
     }
 

src/contracts/Event/ContentProxyCreateEvent.php

@@ -19,28 +19,16 @@ class ContentProxyTranslateEvent extends Event
 {
     private ?Response $response = null;
 
-    private int $contentId;
-
-    private ?string $fromLanguageCode;
-
-    private string $toLanguageCode;
-
     private Options $options;
 
-    private ?int $locationId;
-
     public function __construct(
-        int $contentId,
-        ?string $fromLanguageCode,
-        string $toLanguageCode,
+        private readonly int $contentId,
+        private readonly ?string $fromLanguageCode,
+        private readonly string $toLanguageCode,
         ?Options $options = null,
-        ?int $locationId = null
+        private readonly ?int $locationId = null
     ) {
-        $this->contentId = $contentId;
-        $this->fromLanguageCode = $fromLanguageCode;
-        $this->toLanguageCode = $toLanguageCode;
         $this->options = $options ?? new Options();
-        $this->locationId = $locationId;
     }
 
     public function getContentId(): int

src/contracts/Event/ContentProxyTranslateEvent.php

@@ -13,27 +13,18 @@
 use Ibexa\Contracts\Core\Repository\Values\ContentType\FieldDefinition;
 use Symfony\Contracts\EventDispatcher\Event;
 
-class FieldDefinitionMappingEvent extends Event
+final class FieldDefinitionMappingEvent extends Event
 {
     /**
      * Triggered when contentTypeData is created from contentTypeDraft.
      */
-    public const NAME = 'field_definition.mapping';
-
-    private FieldDefinitionData $fieldDefinitionData;
-
-    private ?Language $baseLanguage;
-
-    private ?Language $targetLanguage;
+    public const string NAME = 'field_definition.mapping';
 
     public function __construct(
-        FieldDefinitionData $fieldDefinitionData,
-        ?Language $baseLanguage,
-        ?Language $targetLanguage
+        private FieldDefinitionData $fieldDefinitionData,
+        private readonly ?Language $baseLanguage,
+        private readonly ?Language $targetLanguage
     ) {
-        $this->baseLanguage = $baseLanguage;
-        $this->targetLanguage = $targetLanguage;
-        $this->fieldDefinitionData = $fieldDefinitionData;
     }
 
     public function getFieldDefinition(): FieldDefinition

src/contracts/Event/FieldDefinitionMappingEvent.php

@@ -12,11 +12,8 @@
 
 final class FocusModeChangedEvent extends Event
 {
-    private bool $enabled;
-
-    public function __construct(bool $enabled)
+    public function __construct(private readonly bool $enabled)
     {
-        $this->enabled = $enabled;
     }
 
     public function isEnabled(): bool

src/contracts/Event/FocusModeChangedEvent.php

@@ -12,47 +12,26 @@
 use Symfony\Component\Form\FormInterface;
 use Symfony\Component\HttpFoundation\Response;
 
-class FormActionEvent extends FormEvent
+final class FormActionEvent extends FormEvent
 {
-    /**
-     * Name of the button used to submit the form.
-     */
-    private ?string $clickedButton;
-
-    /**
-     * Hash of options.
-     *
-     * @var array<string, mixed>
-     */
-    private array $options;
-
     /**
      * Response to return after form post-processing. Typically, a RedirectResponse.
      */
-    private ?Response $response;
-
-    /**
-     * Additional payload populated for event listeners next in priority.
-     *
-     * @var array<mixed>
-     */
-    private array $payloads;
+    private ?Response $response = null;
 
     /**
+     * @param \Symfony\Component\Form\FormInterface<mixed> $form
      * @param array<string, mixed> $options
-     * @param array<mixed> $payloads
+     * @param array<mixed> $payloads additional payloads populated for event listeners next in priority
      */
     public function __construct(
         FormInterface $form,
         mixed $data,
-        ?string $clickedButton,
-        array $options = [],
-        array $payloads = []
+        private readonly ?string $clickedButton,
+        private readonly array $options = [],
+        private array $payloads = []
     ) {
         parent::__construct($form, $data);
-        $this->clickedButton = $clickedButton;
-        $this->options = $options;
-        $this->payloads = $payloads;
     }
 
     public function getClickedButton(): ?string