-
Notifications
You must be signed in to change notification settings - Fork 2
fix: update dialog responsiveness #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s-to-latest-versions
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates all dependencies and devDependencies to their latest versions and migrates the ESLint configuration to the new flat config format. Additionally, it includes code improvements to fix React best practices issues and addresses overflow issues in dialogs on small screens.
- Migrated from legacy
.eslintrc.cjsto ESLint flat config (eslint.config.js) - Updated all npm dependencies to latest versions (React 19.2.0, ESLint 9.39.1, TypeScript 5.9.3, Vite 7.2.2, etc.)
- Refactored state management to use URL-derived state instead of useEffect patterns
- Fixed dialog overflow issues on small screens with max-height constraint
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated all dependencies and devDependencies to latest versions |
| eslint.config.js | New ESLint flat config file replacing legacy .eslintrc.cjs |
| .eslintrc.cjs | Removed legacy ESLint config file |
| src/views/myData/addProtectedData.tsx | Refactored state management to derive currentStep from URL, replaced JSX.Element with ReactElement |
| src/layouts/OnboardingPopup.tsx | Converted callback to useCallback with proper dependencies and wrapped state update in setTimeout |
| src/components/ui/dialog.tsx | Added max-height constraint and overflow-auto to fix small screen issues |
| src/components/PaginatedNavigation.tsx | Changed JSX.Element type to ReactElement |
| src/utils/getBasename.ts | Removed process.env.VERCEL_ENV fallback |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
On small screens, dialog usage can cause overflow issues.