Skip to content

Conversation

@ErwanDecoster
Copy link
Member

On small screens, dialog usage can cause overflow issues.

@vercel
Copy link

vercel bot commented Nov 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
web3-messaging-usecase-demo Ready Ready Preview Comment Nov 12, 2025 2:41pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates all dependencies and devDependencies to their latest versions and migrates the ESLint configuration to the new flat config format. Additionally, it includes code improvements to fix React best practices issues and addresses overflow issues in dialogs on small screens.

  • Migrated from legacy .eslintrc.cjs to ESLint flat config (eslint.config.js)
  • Updated all npm dependencies to latest versions (React 19.2.0, ESLint 9.39.1, TypeScript 5.9.3, Vite 7.2.2, etc.)
  • Refactored state management to use URL-derived state instead of useEffect patterns
  • Fixed dialog overflow issues on small screens with max-height constraint

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
package.json Updated all dependencies and devDependencies to latest versions
eslint.config.js New ESLint flat config file replacing legacy .eslintrc.cjs
.eslintrc.cjs Removed legacy ESLint config file
src/views/myData/addProtectedData.tsx Refactored state management to derive currentStep from URL, replaced JSX.Element with ReactElement
src/layouts/OnboardingPopup.tsx Converted callback to useCallback with proper dependencies and wrapped state update in setTimeout
src/components/ui/dialog.tsx Added max-height constraint and overflow-auto to fix small screen issues
src/components/PaginatedNavigation.tsx Changed JSX.Element type to ReactElement
src/utils/getBasename.ts Removed process.env.VERCEL_ENV fallback

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ErwanDecoster ErwanDecoster changed the title chore: update dependencies and devDependencies to latest versions fix: update DialogContent styles for improved appearance and responsiveness Nov 12, 2025
@ErwanDecoster ErwanDecoster changed the title fix: update DialogContent styles for improved appearance and responsiveness fix: update dialog responsiveness Nov 12, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ErwanDecoster ErwanDecoster merged commit 5a17d1f into main Nov 13, 2025
10 checks passed
@ErwanDecoster ErwanDecoster deleted the fix/update-dialog-responsiveness branch November 13, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants