bugfix: values representing numbers should be provided as instances of java.lang.Double

Author: HardworkingMarek

build.gradle

@@ -50,7 +50,7 @@ publishing {
         maven(MavenPublication) {
             groupId = 'de.inetsoftware'
             artifactId = 'exceljconnect'
-            version = '1.3'
+            version = '1.4'
             from components.java
             pom {
                 name = 'Excel driver for Java'

src/com/inet/excel/ExcelDriver.java

@@ -35,7 +35,7 @@ public class ExcelDriver implements Driver {
     public static final String URL_PREFIX    = "jdbc:inetexcel:";
     public static final String DRIVER_NAME   = "inetexcel";
     public static final int    MAJOR_VERSION = 1;
-    public static final int    MINOR_VERSION = 3;
+    public static final int    MINOR_VERSION = 4;
 
     /** Throws exception indicating that requested operation is not supported.
      * @throws SQLException exception indicating that requested operation is not supported.

src/com/inet/excel/parser/ExcelParser.java

@@ -102,6 +102,7 @@ public String getFileName() {
     public List<String> getColumnNames( String sheetName ) {
         try( ZipFile zipFile = new ZipFile( filePath.toString() ) ) {
             initSheetData( zipFile );
+            initStyles( zipFile );
             initDimensionAndColumnNames( zipFile, sheetName );
             return Collections.unmodifiableList( sheetNamesToColumnNames.get( sheetName ) );
         } catch( IOException ex ) {
@@ -184,6 +185,7 @@ public List<List<Object>> getRows( String sheetName, int firstRowIndex, int last
             initSheetData( zipFile );
             initStyles( zipFile );
             initDimensionAndColumnNames( zipFile, sheetName );
+            initColumnTypes( zipFile, sheetName );
             if( hasHeaderRow ) {
                 // should skip header row
                 firstRowIndex++;
@@ -785,6 +787,14 @@ private List<List<Object>> readRows( ZipFile zipFile, String sheetName, int firs
                                         if( columnIndex > 0 ) { // ensures that cell ref is valid
                                             columnIndex -= sheetDimension.getFirstColumnIndex();
                                             if( columnIndex >= 0 && columnIndex < columnCount ) {
+                                                ValueType columnType = sheetNamesToColumnTypes.get( sheetName ).get( columnIndex );
+                                                if( value instanceof String && columnType == ValueType.NUMBER ) {
+                                                    try {
+                                                        value = Double.valueOf( (String)value );
+                                                    } catch( Exception ex ) {
+                                                        // fallback to string value
+                                                    }
+                                                }
                                                 row.set( columnIndex, value );
                                             }
                                         }

test/com/inet/excel/parser/ExcelParserTest.java

@@ -340,6 +340,16 @@ public void values_representing_date_or_time_are_provided_as_instances_of_time_o
         assertEquals( asList( asList( time, time, time, time ) ), parser.getRows( sheetName, 10, 10 ) );
     }
 
+    @Test
+    public void values_representing_numbers_are_provided_as_instances_of_double() {
+        File resource = new File( ExcelParserTest.class.getResource( "./files/numbers.xlsx" ).getPath() );
+        ExcelParser parser = new ExcelParser( resource.toPath(), false );
+
+        List<Object> expectedRow = asList( Double.valueOf( 123 ), Double.valueOf( 456 ), Double.valueOf( 789 ), Double.valueOf( 321 ), Double.valueOf( 55 ), Double.valueOf( 33 ), Double.valueOf( 10 ) );
+
+        assertEquals( asList( expectedRow ), parser.getRows( "Sheet1", 1, 1 ) );
+    }
+
     @Test
     public void getColumnTypes_throws_exception_if_excel_file_does_not_exist() {
         method_throws_exception_if_excel_file_does_not_exist( parser -> parser.getColumnTypes( "sheetName" ) );