-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Remove liger loss in favor of liger kernel #4364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@qgallouedec we are just investigating the failing tests |
|
Failing tests seem unrelated |
|
This should be made backward compatible:
In my opinion, the removal version can be 0.28 in the 3 cases. |
|
Thanks for the review @qgallouedec! Updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just some comments to improve the deprecation cycle for backward compatibility.
Co-authored-by: Albert Villanova del Moral <[email protected]>
Co-authored-by: Albert Villanova del Moral <[email protected]>
Co-authored-by: Albert Villanova del Moral <[email protected]>
What does this PR do?
Remove
use_liger_lossin favor ofuse_liger_kernelfrom trainers and configs.That flag comes from transformers so we can directly retrieve it from there
Before submitting
Pull Request section?
to it if that's the case.
Who can review?
@kashif @qgallouedec