All status codes are 200

[djpimp2010]

I have installed your proxy from your git repo 2014-02-28.

I have set up some custom actions, but when I get the status code of the response, it is always 200, even when my backend apache/nginx servers return a 502/404/301 etc.

var status = res.statusCode;

I also cannot get a valid referrer header, but thats not as important, and shouldnt really take over this issue.

[jcrugzz]

@djpimp2010 I have not seen this at all, could you please provide reproducible test case for this so we can get to the bottom of why this could be happening? Thanks! :)

[djpimp2010]

@jcrugzz

Yes, of course... I have a basic node-js install, default locations...

Here is my code, I have the extra libraries 'node-mysql' , 'fs' and 'util' installed for custom actions:

/*includes*/
var http = require('http');
var httpProxy = require('http-proxy');
var fs = require('fs');
var util = require('util');

/*open log file for write*/
var log_file = fs.createWriteStream('/var/log/httpproxy/debug.log', {flags : 'a'});

/*overwrite console.log() function to write to file*/
console.log = function(d) {
  log_file.write(util.format(d) + '\n');
};

/*simple function to parse array for host and return ip*/
Array.prototype.contains = function ( needle ) {
   for (i in this) {
       if (this[i]['host'] === needle){
        return this[i]['ip'];
       }
       if ('www.' + this[i]['host'] === needle){
        return this[i]['ip'];
       }
   }
   return false;
}

/*open mysql connection to proxy, with host/ip settings*/
var mysql = require('mysql');
var connection1 = mysql.createConnection({
        host    : '192.168.0.11',
        user    : 'root',
        password: '**********',
        database: 'proxy'
});

/*connect to the database or log error*/
connection1.connect(function(err){
        if(err){
            console.log(err);
            return;
        }
});

/*get array of all valid host/ip configs*/
connection1.query('SELECT * from http', function(err, rows, fields) {
    if (err) {
        console.log(err);
        return;
    } else {
        hosts = rows;
    }
});

/*close connection to proxy settings db*/
connection1.end();

/*open mysql connection to logging database*/
var connection2 = mysql.createConnection({
        host    : '127.0.0.1',
        user    : 'logs',
        password: '**********',
        database: 'logs'
});

/*connect to the database or log error*/
connection2.connect(function(err){
        if(err){
            console.log(err);
            return;
        }
});

/*create actual proxy request server*/
var proxy = httpProxy.createProxyServer({});

/*create http listener server*/
var server = http.createServer(function(req, res) {

    /*search domain against array of hosts/ips*/
    var ip = hosts.contains(domain);

    /*parse req/res for data to log*/
    var domain = req['headers']['host'];
    var d = new Date();
    var utc = d.toUTCString();
    var request = req['method'] + ' ' + req['url'];
    var status = res.statusCode;
    var user = req['headers']['user-agent'];
    var referrer = req.headers.referer;

    /*log data*/
    connection2.query('insert into httpproxy set ?', {ip: req.connection.remoteAddress, host: domain, time: utc, request: request, status: status, header: user }, function(err, rows, fields) {
        if (err) {
            console.log(err);
            return;
        }
    });

    /*if ip is valid, proxy request, or show default website*/
    if(ip){
        var result = proxy.web(req, res, { target: 'http://' + ip , port: 80 });
    } else {
        var result = proxy.web(req, res, { target: 'http://192.168.0.13', port: 80 });
    }



});

/*listen for incoming connections*/
console.log("listening on port 444")
server.listen(444);

This works perfectly, for HTTP connections (except status codes always being 200), although I cannot get it working for HTTPS (name based with SNI) - Thats a different problem!

[djpimp2010]

And just to save hassle, here is a cut down version that always proxies default IP, and a 404 on that request still logs 200...

/*includes*/
var http = require('http');
var httpProxy = require('http-proxy');

/*create actual proxy request server*/
var proxy = httpProxy.createProxyServer({});

/*create http listener server*/
var server = http.createServer(function(req, res) {

    var status = res.statusCode;
    console.log(status);
    var result = proxy.web(req, res, { target: 'http://192.168.0.13', port: 80 });

});

/*listen for incoming connections*/
console.log("listening on port 444")
server.listen(444);

[derekschultz]

@jcrugzz

We are running into this same issue. All requests return a 200 status code.

Included an example below, we can print out the correct status code, however, writeHead doesn't appear to be actually sending the header.

proxy.on('error', function (err, req, res) {
  res.writeHead(404, {
    'Content-Type': 'text/plain'
  });
  util.puts(res.statusCode);
  res.end('Something went turribly wrong');
});

[mars]

We're seeing this problem using the proxy option of Webpack Dev Server

[hatembr]

Hello,
Have this issue been addressed? I am getting exactly the same problem which is totally blocking since actions or custom logic related to actual status codes cannot be implemented in the proxy.

[PhilCorcoran]

check the proxy response status code instead of res.statusCode;

proxy.on('proxyRes', function(proxyRes, req, res) { console.log('status:' + proxyRes.statusCode); res.status(proxyRes.status); });

[hatembr]

That worked.
Thanks for your help.

[nikhilbaradwaj]

@mars - Did you figure out how to resolve this for the webpack dev server case? If so, can you provide your solution.

[jcrugzz]

This still looks like its a bug if it is still happening. Would definitely take a PR to fix this!

[jcrugzz]

if anyone wants to tackle this, we should ensure that this function is getting called. https://github.com/nodejitsu/node-http-proxy/blob/master/lib/http-proxy/passes/web-outgoing.js#L100-L102

[nikhilbaradwaj]

@jcrugzz - On further investigation, it does work as expected for me. The response status was set incorrectly on my server code, the proxy was just returning that incorrect status of 200. Sorry for the false alarm.