Reverted change disabling modal dialogs. For #1747

Author: highperformancecoder

doc/minsky.pdf

@@ -184,7 +184,7 @@ export class WindowManager {
       useContentSize: true,
       minimizable: false,
       show: false,
-      parent: null /* modal ? mainWindow : null */, // Having a parent hides control on MacOS
+      parent: modal ? this.getMainWindow() : null,
       modal,
       backgroundColor,
       alwaysOnTop,

gui-js/apps/minsky-electron/src/app/managers/WindowManager.ts

@@ -136,6 +136,8 @@ export class CreateVariableComponent implements OnInit, OnDestroy {
   async updateFormValues() {
     let item=new VariableBase(this.electronService.minsky.canvas.item);
     const local = await item.local();
+    // check there is an item of the right type
+    if (typeof local==='object') this.closeWindow();
     const init = await item.init();
     const units = await item.unitsStr();
     const rotation = await item.rotation();