Remove Html.Parser.Util.toVirtualDomSvg

Author: hecrj

CHANGELOG.md

@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## [2.0.0] - 2018-12-06
+### Removed
+- `Html.Parser.Util.toVirtualDomSvg` as parsing of SVG nodes is not implemented yet.
+
 ## [1.1.0] - 2018-12-06
 ### Added
 - `Html.Parser.Util` to transform parser nodes into virtual dom nodes.
@@ -22,6 +26,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 [named-character-references]: https://www.w3.org/TR/html5/syntax.html#named-character-references
 
-[Unreleased]: https://github.com/hecrj/html-parser/compare/1.1.0...HEAD
+[Unreleased]: https://github.com/hecrj/html-parser/compare/2.0.0...HEAD
+[2.0.0]: https://github.com/hecrj/html-parser/compare/1.1.0...2.0.0
 [1.1.0]: https://github.com/hecrj/html-parser/compare/1.0.1...1.1.0
 [1.0.1]: https://github.com/hecrj/html-parser/compare/1.0.0...1.0.1

README.md

@@ -10,7 +10,10 @@ Html.Parser.run "<div><p>Hello, world!</p></div>"
 ```
 
 ## Limitations
-  * `<script>` tags are not fully supported yet! Feel free to contribute!
+  * `<script>` tags are not fully supported.
+  * SVG is not supported.
+
+Feel free to contribute!
 
 
 ## Contributing / Feedback

elm.json

@@ -3,7 +3,7 @@
     "name": "hecrj/html-parser",
     "summary": "Parse HTML 5 in Elm",
     "license": "BSD-3-Clause",
-    "version": "1.1.0",
+    "version": "2.0.0",
     "exposed-modules": [
         "Html.Parser",
         "Html.Parser.Util"
@@ -13,7 +13,6 @@
         "elm/core": "1.0.0 <= v < 2.0.0",
         "elm/html": "1.0.0 <= v < 2.0.0",
         "elm/parser": "1.0.0 <= v < 2.0.0",
-        "elm/svg": "1.0.1 <= v < 2.0.0",
         "elm/virtual-dom": "1.0.2 <= v < 2.0.0",
         "rtfeldman/elm-hex": "1.0.0 <= v < 2.0.0"
     },

src/Html/Parser/Util.elm

@@ -1,19 +1,17 @@
-module Html.Parser.Util exposing (toVirtualDom, toVirtualDomSvg)
+module Html.Parser.Util exposing (toVirtualDom)
 
 {-| Utility functions that may help you digging into the contents.
 
 
 # Virtual DOM
 
-@docs toVirtualDom, toVirtualDomSvg
+@docs toVirtualDom
 
 -}
 
 import Html exposing (..)
 import Html.Attributes exposing (..)
 import Html.Parser exposing (Node(..))
-import Svg exposing (Svg)
-import Svg.Attributes
 import VirtualDom
 
 
@@ -28,11 +26,7 @@ toVirtualDomEach : Node -> Html msg
 toVirtualDomEach node =
     case node of
         Element name attrs children ->
-            if name == "svg" then
-                toVirtualDomSvgEach node
-
-            else
-                Html.node name (List.map toAttribute attrs) (toVirtualDom children)
+            Html.node name (List.map toAttribute attrs) (toVirtualDom children)
 
         Text s ->
             text s
@@ -44,45 +38,3 @@ toVirtualDomEach node =
 toAttribute : ( String, String ) -> Attribute msg
 toAttribute ( name, value ) =
     attribute name value
-
-
-{-| Converts nodes to virtual dom SVG nodes.
-
-Note: If node list contains `<svg>` tag, you can use `toVirtualDom` instead.
-Otherwise, use this function.
-
-    svg : Svg msg
-    svg =
-        parse """<circle cx="40" cy="40" r="24" style="stroke:#006600; fill:#00cc00"/>"""
-            |> toVirtualDomSvg
-            |> Svg.svg []
-
--}
-toVirtualDomSvg : List Node -> List (Svg msg)
-toVirtualDomSvg nodes =
-    List.map toVirtualDomSvgEach nodes
-
-
-toVirtualDomSvgEach : Node -> Svg msg
-toVirtualDomSvgEach node =
-    case node of
-        Element name attrs children ->
-            Svg.node name (List.map toSvgAttribute attrs) (toVirtualDomSvg children)
-
-        Text s ->
-            text s
-
-        Comment _ ->
-            text ""
-
-
-toSvgAttribute : ( String, String ) -> Attribute msg
-toSvgAttribute ( name, value ) =
-    if String.startsWith "xlink:" name then
-        VirtualDom.attributeNS "http://www.w3.org/1999/xlink" name value
-
-    else if String.startsWith "xml:" name then
-        VirtualDom.attributeNS "http://www.w3.org/XML/1998/namespace" name value
-
-    else
-        VirtualDom.attribute name value