Merge pull request #218 from mr-miles/patch-1

brikis98 · web-flow · commit af53a3f74c89 · 2021-05-03T11:57:04.000+01:00
Set up http_api access correctly
diff --git a/modules/consul-security-group-rules/main.tf b/modules/consul-security-group-rules/main.tf
@@ -68,7 +68,7 @@ resource "aws_security_group_rule" "allow_http_api_inbound" {
 }
 
 resource "aws_security_group_rule" "allow_https_api_inbound" {
-  count       = var.enable_https_port ? 1 : 0
+  count       = var.enable_https_port && length(var.allowed_inbound_cidr_blocks) >= 1 ? 1 : 0
   type        = "ingress"
   from_port   = var.https_api_port
   to_port     = var.https_api_port

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ resource "aws_security_group_rule" "allow_http_api_inbound" {`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`resource "aws_security_group_rule" "allow_https_api_inbound" {`
`71`		`- count = var.enable_https_port ? 1 : 0`
	`71`	`+ count = var.enable_https_port && length(var.allowed_inbound_cidr_blocks) >= 1 ? 1 : 0`
`72`	`72`	`type = "ingress"`
`73`	`73`	`from_port = var.https_api_port`
`74`	`74`	`to_port = var.https_api_port`