Add commits from old git repo (git://git.sr71.net/gmailfs.git) #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and make the exception handling a bit more concise
I encoded the path, but didn't decode it, so if there was a / in the link: lrwxrwxrwx 1 dave dave 0 2011-01-08 11:52 fstest_2ae632ecf36446af4c385b196f944404 -> __fs__fstest_0282f55576d57179fef3f9336df52e1c__fs__fstest_1512bf64248c80b21afc9911cc5a4bca
I could be a lot better about these changelogs. This adds some debugging for things that hung during dirtying operations
The basic problem is that we can't block dirty writeout by marking an object dirty. So, we have to make a way to remember dirty objects in a non-blocking way. So, we create a non-size-limited Queue for these, then tie that queue back in to the existing one that _can_ block.
I need to be better about committing these things in smaller pieces, I know. I promise I'll get better if/when I start getting more patches. :)
the read() code used to delete messages after it read them. Whoops. - self.populate_buffer(1) + self.populate_buffer(KEEP_AFTER_READ)
There was a bug both in directory creation and another in unlink() that caused nlink screwups. Those are fixed. This also continues to improve the new fsck code.
This probably never worked. Fix from [email protected]: The problem is replace doesn't map a set of characters, just the literal string as the first argument. You need something like translate like the above code. Maybe in your tests, you see the literal sequence "\r\n\t" you want to translate to a " ". Or maybe your replace behaves differently in python 2.7.2+. I don't know. This patch fixes me. If it works for you, then call it good. After making this change, I now have a gmail filesystem mounted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I switched my remote over to this github repo, only to find that some commits were missing.
This PR will add the missing commits, made by you @hansendc, from 2011-01-08 thru 2011-11-28.