-
Notifications
You must be signed in to change notification settings - Fork 25
[QoL] Flag missing merchant info #9940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I also don't know how to assign this issue to me, so consider this issue assigned to me! |
I tried and failed to do this. turns out you actually need to know ruby. If anyone wants a stab at this, I think you can pop in a new bit of code (duh) in <%# --- this assumes that all flaggable transactions can be improved --- %>
<%# --- there's probably a much better way of doing this, but I haven't found that yet --- %>
<% if flagable %>
<% fillout_url = "https://forms.hackclub.com/hcb-txn?mid=#{hcb_code.merchant_mid}&name=#{hcb_code.raw_name}" %>
<%= link_to fillout_url, target: "_blank", class: "flex items-center" do %>
<%= inline_icon "edit", size: 24 %>
Improve merchant information
<% end %>
<% end %> However! I have not a single clue where I'd get the MID or transaction name from. I did make up the |
screen-20250323-125843.mp4Something like this! |
This is a cool idea! Is the Fillout form ready to go? I can take your code and put something together - it seems pretty close. Though I'd recommend trying to debug it yourself and get it working - that's the best way to learn. |
Fillout is good to go! To be honest, I'm really not sure where to start. I can make the button, but have no idea how to pull MIDs or raw transaction names? |
Hey @leowilkin, who will be responsible for processing these fillout submissions and getting them into yellow pages. You mentioned the yellow pages review team, but that's largely just the HCB engineering team at the moment and I'm not sure that we have the capacity to take this on. Maybe someone on the operations side can handle this? If so, they need to:
|
@garyhtou a community team, like the ex-open sourcerers, or the Dino review team? Do you think that would work? I know engineering probably doesn't have the capacity for something like this. |
I'd be down to help out if needed. I've started to see the yellow pages contributions die out over time and still some PRs (including mine 😭 ) are left unmerged. I've been thinking of a way such as what Leo said or if I have time to add merchant IDs to the v3 API I could write a quick script to compile memos and the merchant IDs and try to pair them ig. But tldr is we need some team to review and grow the yellow pages list. |
Fyi @leowilkin, I'm chatting with @thedev132 about this since Graham and other YSWS organizers may want to contribute to Yellow Pages to make it more robust (and in turn make the Card Grant managing experience less tedious). |
Y'know how we get questions about
Unnamed merchant
, and we have our Yellow Pages directory to add cute metadata to transactions, like logos and names?Like Monzo (screen recording to follow), wouldn't it be nice if we could get a little extra option in the transaction 'three dot' dropdown, allowing users to add more information about a vendor, like their name, or website, so we can improve Yellow Pages!
Ideal scenario
Say we find a new JLCPCB vendor ID - it shows up as Unnamed merchant on HCB grant cards, and doesn't have the JLC logo on the ledger.
Improve merchant information
Implementation ideas
I'm thinking of using Fillout for this initially, cause I know how do to Fillout URL params, and it shouldn't be too difficult (he says).
Eventually, it would be swell if I could figure out how to put this in HCB natively probably stealing some popout code from another process/component.
The text was updated successfully, but these errors were encountered: