Skip to content

Commit 6f5d3f6

Browse files
committed
Update dependencies
1 parent e00d2bc commit 6f5d3f6

File tree

716 files changed

+79537
-42632
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

716 files changed

+79537
-42632
lines changed

Gopkg.lock

Lines changed: 15 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

command/autoRebase_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -706,7 +706,7 @@ func TestCmdAutoRebaseBadAPIURL(t *testing.T) {
706706
app := cli.NewApp()
707707
cb := &runner.Test{}
708708
err := command.CmdAutoRebase(cb)(cli.NewContext(app, set, nil))
709-
assert.EqualError(t, err, "parse %s/mockApi: invalid URL escape \"%s/\"")
709+
assert.EqualError(t, err, "parse %s/mockApi/: invalid URL escape \"%s/\"")
710710
}
711711

712712
func TestCmdAutoRebaseUserFailure(t *testing.T) {

command/parse_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ func TestCmdParseBadApiUrl(t *testing.T) {
193193
set := getBaseFlagSet(configFileName)
194194
app := cli.NewApp()
195195
err := command.CmdParse(cli.NewContext(app, set, nil))
196-
assert.EqualError(t, err, "parse %s/mockApi: invalid URL escape \"%s/\"")
196+
assert.EqualError(t, err, "parse %s/mockApi/: invalid URL escape \"%s/\"")
197197
}
198198

199199
func TestCmdParseUserFailure(t *testing.T) {
@@ -326,7 +326,7 @@ func TestCmdParseCommitCompareFailure(t *testing.T) {
326326
}
327327

328328
func TestCmdParseReviewFailure(t *testing.T) {
329-
ts := getParseTestServer("/repos/foo/bar/pulls/1/reviews")
329+
ts := getParseTestServer("/repos/foo/bar/pulls/1/reviews?per_page=100")
330330
defer ts.Close()
331331
_, configFileName := getConfigWithAPIURL(t, ts.URL)
332332
defer removeFile(t, configFileName)

command/pullRequest.go

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -104,16 +104,25 @@ func (pr pullRequest) getComments() <-chan *github.IssueComment {
104104
}
105105

106106
func (pr pullRequest) getReviews() <-chan *github.PullRequestReview {
107+
opt := &github.ListOptions{PerPage: 100}
107108
allReviews := make(chan *github.PullRequestReview)
108109
go func() {
109110
defer close(allReviews)
110-
reviews, _, err := pr.client.PullRequests.ListReviews(context.Background(), pr.Repo.Owner, pr.Repo.Name, pr.PullRequestID)
111-
if err != nil {
112-
return
113-
}
111+
for {
112+
reviews, resp, err := pr.client.PullRequests.ListReviews(context.Background(), pr.Repo.Owner, pr.Repo.Name, pr.PullRequestID, opt)
113+
if err != nil {
114+
return
115+
}
116+
117+
for _, review := range reviews {
118+
allReviews <- review
119+
}
120+
121+
if resp.NextPage == 0 {
122+
return
123+
}
114124

115-
for _, review := range reviews {
116-
allReviews <- review
125+
opt.Page = resp.NextPage
117126
}
118127
}()
119128
return allReviews

command/util_test.go

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ func getConfigWithAPIURL(t *testing.T, url string) (config.PrpConfig, string) {
102102
t.Helper()
103103
conf, configFileName := getConfigWithIgnoredBuild(t)
104104
profile := conf.Profiles["foo"]
105-
profile.APIURL = url
105+
profile.APIURL = fmt.Sprintf("%s/", url)
106106
profile.Token = "abc"
107107
conf.Profiles["foo"] = profile
108108
assert.Nil(t, conf.Write(configFileName))
@@ -221,15 +221,15 @@ func handleCommentRequests(r *http.Request, w http.ResponseWriter, server *httpt
221221
}
222222

223223
func handleReviewRequests(r *http.Request, w http.ResponseWriter, server *httptest.Server) *string {
224-
if r.URL.String() == "/repos/own/rep/pulls/1/reviews" {
224+
if r.URL.String() == "/repos/own/rep/pulls/1/reviews?per_page=100" {
225225
bytes, _ := json.Marshal([]*github.PullRequestReview{
226226
newReview("fooGuy"),
227227
})
228228
w.Header().Set(
229229
"Link",
230230
fmt.Sprintf(
231-
`<%s/mockApi/repos/own/rep/issues/1/comments?per_page=100&page=2>; rel="next", `+
232-
`<%s/mockApi/repos/own/rep/issues/1/comments?per_page=100&page=2>; rel="last"`,
231+
`<%s/mockApi/repos/own/rep/pulls/1/reviews?per_page=100&page=2>; rel="next", `+
232+
`<%s/mockApi/repos/own/rep/pulls/1/reviews?per_page=100&page=2>; rel="last"`,
233233
server.URL,
234234
server.URL,
235235
),
@@ -238,7 +238,16 @@ func handleReviewRequests(r *http.Request, w http.ResponseWriter, server *httpte
238238
return &response
239239
}
240240

241-
if r.URL.String() == "/repos/foo/bar/pulls/1/reviews" {
241+
if r.URL.String() == "/repos/own/rep/pulls/1/reviews?page=2&per_page=100" {
242+
243+
bytes, _ := json.Marshal([]*github.PullRequestReview{
244+
newReview("fooGuy"),
245+
})
246+
response := string(bytes)
247+
return &response
248+
}
249+
250+
if r.URL.String() == "/repos/foo/bar/pulls/1/reviews?per_page=100" {
242251
bytes, _ := json.Marshal([]*github.PullRequestReview{
243252
newReview("guy"),
244253
newReview("own"),
@@ -249,15 +258,15 @@ func handleReviewRequests(r *http.Request, w http.ResponseWriter, server *httpte
249258
return &response
250259
}
251260

252-
if r.URL.String() == "/repos/own/rep/pulls/2/reviews" {
261+
if r.URL.String() == "/repos/own/rep/pulls/2/reviews?per_page=100" {
253262
bytes, _ := json.Marshal([]*github.PullRequestReview{
254263
newReview("guy"),
255264
})
256265
response := string(bytes)
257266
return &response
258267
}
259268

260-
if r.URL.String() == "/repos/foo/bar/pulls/2/reviews" {
269+
if r.URL.String() == "/repos/foo/bar/pulls/2/reviews?per_page=100" {
261270
bytes, _ := json.Marshal([]*github.PullRequestReview{
262271
newReview("guy2"),
263272
})

vendor/github.com/golang/protobuf/.travis.yml

Lines changed: 17 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/golang/protobuf/README.md

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/golang/protobuf/_conformance/conformance_proto/conformance.pb.go

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)