Menu borders latest V2

[cjlotz]

Hi Folks

I've updated our application to latest v2 Alpha releases and I've noticed that the menu is presenting differently now with no border lines around it. Here is a screen shot of the old menu

and here is a screenshot of the new menu.

What recent API/behaviour change will cause this and how can I get the menu to use the old styling again? Here is a snippet where I am constructing the menu. I see the Catalog sample also has no borders on the menu. Is this by design? Is there any way to restore the old look and feel? I tried different BorderStyle settings but this does not seem to have an effect.

    private void InitialiseViews()
    {
        MenuBar = new MenuBarv2(
                  [
                      new("Licence _Generator",
                      [
                          new MenuItemv2("_About Licence Generator", "", () => ViewHelper.ShowMessage(50, 10, GetVersionInfo(), "About On Key Licence Generator"), Key.F1),
                          null,
                          new MenuItemv2("_Connect to On Key...", "", _main.ConnectToOnKey, Key.F6),
                          new MenuItemv2("_Generate Licence Report...", "", _main.GenerateLicenceReport, Key.E.WithCtrl),
                          new MenuItemv2("_Refresh On Key Tenants...", "", _main.GetOnKeyTenants, Key.F7),
                          new MenuItemv2("_Disconnect On Key", "", _main.DisconnectFromOnKey),
                          null,
                          new MenuItemv2("Connect to Password Safe...", "", _main.ConnectToSecretStore),
                          new MenuItemv2("Disconnect Password Safe", "", _main.DisconnectFromSecretStore),
                          null,
                          new MenuItemv2 { Title = "_Quit", Command = Command.Quit, Key = Application.QuitKey }
                      ]),
                      new("_Licence",
                      [
                          new MenuItemv2("_New...", "", _main.NewLicence, Key.F2),
                          new MenuItemv2("_Open...", "", _main.OpenLicence, Key.F3),
                          new MenuItemv2("_Save...", "", _main.SaveLicence, Key.F4),
                          new MenuItemv2("Clear", "", _editor.ClearLicence),
                          null,
                          new MenuItemv2
                          {
                              Title = "Copy",
                              SubMenu = new(
                              [
                                  new MenuItemv2("Encrypted licence", "", () => _editor.CopyLicenceToClipboard(true)),
                                  new MenuItemv2("Clear text licence", "", () => _editor.CopyLicenceToClipboard(false))
                              ])
                          },
                          new MenuItemv2
                          {
                              Title = "Paste",
                              SubMenu = new(
                              [
                                  new MenuItemv2("Encrypted licence", "", () => _editor.PasteLicenceFromClipboard(true)),
                                  new MenuItemv2("Clear text licence", "", () => _editor.PasteLicenceFromClipboard(false))
                              ])
                          },
                      ]),
                      new("_Certificate",
                      [
                          new MenuItemv2("Open...", "", _editor.OpenCertificateFromFile, Key.F8),
                          new MenuItemv2("Clear", "", _editor.ClearCertificate),
                          null,
                          new MenuItemv2("Copy Public Key", "", _editor.ExportCertificateToClipboard)
                      ])
                  ])
                  {
                      Title = "On Key Licence Generator"
                  };
        }

[tig]

This is controlled by Menuv2.DefaultBorderStyle.

The hardcoded value is None.

This can be changed via config. Read up on Configuration Manager to see your options for how to control this.

https://gui-cs.github.io/Terminal.Gui/docs/config.html

We made this change because we feel that TUI screen real estate is valuable and the border doesn't add much value. We also want to drive a distinct look and feel for v2 default vs v1.

The design is not final. We'd appreciate any input you have on this here:

#3493 (comment)

[cjlotz]

Thanks for the quick feedback. I personally don't mind the refreshed look, but our user base is very resistant to change. Having the ability to opt out the default new look-and-feel and revert back to the old look-and-feel would be very handy. We don't want to disrupt our existing user base if at all possible. If this is already possible via the Configuration Manager, I will investigate this further. To summarize, we would like to stick with the updates but, if possible, have an easy way to still use the old look. Potentially have a style that maps to the old look?

[tig]

CM makes it easy for your app it overrides the default theme.